[PR #1407] [MERGED] Fix a missing close parenthesis before '.then' #3292

New issue

Closed

opened 2026-03-17 00:55:13 +03:00 by kerem · 0 comments

kerem commented

2026-03-17 00:55:13 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hoppscotch/hoppscotch/pull/1407
Author: @sakurayang
Created: 1/2/2021
Status: ✅ Merged
Merged: 1/2/2021
Merged by: @liyasthomas

Base: main ← Head: patch-1

📝 Commits (2)

bd9add4 Fix a missing close parenthesis before '.then'
e103997 Fix a missing close parenthesis before '.then'

📊 Changes

2 files changed (+5 additions, -5 deletions)

View changed files

📝 helpers/codegen/__tests__/__snapshots__/codegen.spec.js.snap (+4 -4)
📝 helpers/codegen/generators/nodejs-axios.js (+1 -1)

📄 Description

Origin generators:

axios.post('address', {
    // request body
},{
  headers : {
    // request head
}.then(response => {
    console.log(response);
}).catch(error => {
    console.log(error);
})

after fix:

axios.post('address', {
    // request body
},{
  headers : {
    // request head
}).then(response => {
    console.log(response);
}).catch(error => {
    console.log(error);
})

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hoppscotch/hoppscotch/pull/1407 **Author:** [@sakurayang](https://github.com/sakurayang) **Created:** 1/2/2021 **Status:** ✅ Merged **Merged:** 1/2/2021 **Merged by:** [@liyasthomas](https://github.com/liyasthomas) **Base:** `main` ← **Head:** `patch-1` --- ### 📝 Commits (2) - [`bd9add4`](https://github.com/hoppscotch/hoppscotch/commit/bd9add4cbb2d50e7bb60930cfda9dd0644a247b3) Fix a missing close parenthesis before '.then' - [`e103997`](https://github.com/hoppscotch/hoppscotch/commit/e103997ce3bd7ef8a290dc9580cba2795aad30cb) Fix a missing close parenthesis before '.then' ### 📊 Changes **2 files changed** (+5 additions, -5 deletions) <details> <summary>View changed files</summary> 📝 `helpers/codegen/__tests__/__snapshots__/codegen.spec.js.snap` (+4 -4) 📝 `helpers/codegen/generators/nodejs-axios.js` (+1 -1) </details> ### 📄 Description Origin generators: ```javascript axios.post('address', { // request body },{ headers : { // request head }.then(response => { console.log(response); }).catch(error => { console.log(error); }) ``` after fix: ```javascript axios.post('address', { // request body },{ headers : { // request head }).then(response => { console.log(response); }).catch(error => { console.log(error); }) ``` --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>