[PR #1338] [CLOSED] Add check for socket object #3249

Closed
opened 2026-03-17 00:52:47 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/hoppscotch/hoppscotch/pull/1338
Author: @opensorceror
Created: 11/21/2020
Status: Closed

Base: mainHead: opensorceror-patch-1


📝 Commits (2)

📊 Changes

2 files changed (+4 additions, -2 deletions)

View changed files

📝 components/realtime/websocket.vue (+3 -1)
📝 package.json (+1 -1)

📄 Description

Fixes a bug where if the socket URL is not reachable, the log window shows "Connecting" indefinitely, with no error message.

Steps to reproduce:

  1. Go to hoppscotch.io
  2. Navigate to the Realtime page
  3. In the Request URL box, enter an invalid URL, for example s or dfgkjhfhkgfhk
  4. Click the Connect button

Expected behaviour: Error is printed in the log window
Actual behaviour: Log window shows "Connecting to <entered_value>" and freezes, while the following error is printed on the console:

TypeError: Cannot read property 'close' of null
    at f.disconnect (f8bbf32.js:1)
    at f.handleError (f8bbf32.js:1)
    at f.connect (f8bbf32.js:1)
    at f.toggleConnection (f8bbf32.js:1)
    at Qt (29d1d29.js:2)
    at HTMLButtonElement.n (29d1d29.js:2)
    at HTMLButtonElement.c._wrapper (29d1d29.js:2)

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/hoppscotch/hoppscotch/pull/1338 **Author:** [@opensorceror](https://github.com/opensorceror) **Created:** 11/21/2020 **Status:** ❌ Closed **Base:** `main` ← **Head:** `opensorceror-patch-1` --- ### 📝 Commits (2) - [`1c35738`](https://github.com/hoppscotch/hoppscotch/commit/1c3573840c856b3ea8e97006a686d5d5e0e570b6) Add check for socket object - [`5442a4a`](https://github.com/hoppscotch/hoppscotch/commit/5442a4aea3e22a63a283937fca5845436a03b189) Version bump ### 📊 Changes **2 files changed** (+4 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `components/realtime/websocket.vue` (+3 -1) 📝 `package.json` (+1 -1) </details> ### 📄 Description Fixes a bug where if the socket URL is not reachable, the log window shows "Connecting" indefinitely, with no error message. Steps to reproduce: 1. Go to [hoppscotch.io](https://hoppscotch.io) 2. Navigate to the Realtime page 3. In the Request URL box, enter an invalid URL, for example `s` or `dfgkjhfhkgfhk` 4. Click the Connect button Expected behaviour: Error is printed in the log window Actual behaviour: Log window shows "Connecting to <entered_value>" and freezes, while the following error is printed on the console: ``` TypeError: Cannot read property 'close' of null at f.disconnect (f8bbf32.js:1) at f.handleError (f8bbf32.js:1) at f.connect (f8bbf32.js:1) at f.toggleConnection (f8bbf32.js:1) at Qt (29d1d29.js:2) at HTMLButtonElement.n (29d1d29.js:2) at HTMLButtonElement.c._wrapper (29d1d29.js:2) ``` --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-03-17 00:52:47 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/hoppscotch#3249
No description provided.