[PR #1248] [MERGED] Fix form post data parsing #3175

New issue

Closed

opened 2026-03-17 00:48:43 +03:00 by kerem · 0 comments

kerem commented

2026-03-17 00:48:43 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hoppscotch/hoppscotch/pull/1248
Author: @yq314
Created: 10/7/2020
Status: ✅ Merged
Merged: 10/7/2020
Merged by: @liyasthomas

Base: master ← Head: fix-form-post-data-parsing

📝 Commits (2)

582abe4 fix data handling in nodejs-request codegen
b9c737d fix quote change

📊 Changes

1 file changed (+15 additions, -6 deletions)

View changed files

📝 helpers/codegen/generators/nodejs-request.js (+15 -6)

📄 Description

This PR is to fix 2 issues in the nodejs-request codegen.

form data with more than 1 key/val pairs are not parsed properly
before:

after:
Screenshot 2020-10-07 at 11 05 03 AM

XML is not quoted properly so it generates broken code
before:

after:
Screenshot 2020-10-07 at 11 05 19 AM

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hoppscotch/hoppscotch/pull/1248 **Author:** [@yq314](https://github.com/yq314) **Created:** 10/7/2020 **Status:** ✅ Merged **Merged:** 10/7/2020 **Merged by:** [@liyasthomas](https://github.com/liyasthomas) **Base:** `master` ← **Head:** `fix-form-post-data-parsing` --- ### 📝 Commits (2) - [`582abe4`](https://github.com/hoppscotch/hoppscotch/commit/582abe46b0c2af2249449c0177f8847e4c8a30aa) fix data handling in nodejs-request codegen - [`b9c737d`](https://github.com/hoppscotch/hoppscotch/commit/b9c737d65f41242d749eda75dfedcc1cac44286c) fix quote change ### 📊 Changes **1 file changed** (+15 additions, -6 deletions) <details> <summary>View changed files</summary> 📝 `helpers/codegen/generators/nodejs-request.js` (+15 -6) </details> ### 📄 Description This PR is to fix 2 issues in the `nodejs-request` codegen. 1. form data with more than 1 key/val pairs are not parsed properly before: <img width="691" alt="Screenshot 2020-10-07 at 11 07 00 AM" src="https://user-images.githubusercontent.com/2336852/95283255-e7f5f900-088d-11eb-9d40-4512b648b671.png"> after: <img width="689" alt="Screenshot 2020-10-07 at 11 05 03 AM" src="https://user-images.githubusercontent.com/2336852/95283262-ed534380-088d-11eb-9264-d35e6796b734.png"> 2. XML is not quoted properly so it generates broken code before: <img width="690" alt="Screenshot 2020-10-07 at 11 06 47 AM" src="https://user-images.githubusercontent.com/2336852/95283290-00661380-088e-11eb-9c18-63eb088804ef.png"> after: <img width="687" alt="Screenshot 2020-10-07 at 11 05 19 AM" src="https://user-images.githubusercontent.com/2336852/95283305-09ef7b80-088e-11eb-8155-d560ff483bb9.png"> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>