mirror of
https://github.com/hoppscotch/hoppscotch.git
synced 2026-04-25 16:55:59 +03:00
[PR #1219] [MERGED] Fixed sidenav animation #3149
Labels
No labels
CodeDay
a11y
browser limited
bug
bug fix
cli
core
critical
design
desktop
discussion
docker
documentation
duplicate
enterprise
feature
feature
fosshack
future
good first issue
hacktoberfest
help wanted
i18n
invalid
major
minor
need information
need testing
not applicable to hoppscotch
not reproducible
pull-request
question
refactor
resolved
sandbox
self-host
spam
stale
testmu
wip
wont fix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/hoppscotch#3149
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
📋 Pull Request Information
Original PR: https://github.com/hoppscotch/hoppscotch/pull/1219
Author: @arshzip
Created: 10/3/2020
Status: ✅ Merged
Merged: 10/3/2020
Merged by: @liyasthomas
Base:
ui← Head:master📝 Commits (3)
c4bca01fixed sidenav icon transitiona9240cefixed transition-property of nav linksc66fe79Merge branch 'master' into master📊 Changes
1 file changed (+2 additions, -0 deletions)
View changed files
📝
components/layout/sidenav.vue(+2 -0)📄 Description
Bug fixed
Sidenav animation did not work
To Reproduce
Click on the sidenav icons. The animation is abrupt.
Expected behavior
The icon should slowly expand when it becomes active.
Explanation
The
border-radiuson the nav link icons was set to9999px, hence transitioning to16pxin 200ms did produce a noticeable change.transition-propertyon thenav > atags did not include border-radius.These were most likely due to Tailwind CSS (or that's what I understood from
@apply)Solution
Set
border-radiusto50%for a circle instead of using9999px.Set
transition-propertytoall !importantfornav > alinks.I have verified that this fixes the animation.
🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.