[PR #1183] [MERGED] Fix Quality Issues using DeepSource #3125

New issue

Closed

opened 2026-03-17 00:46:01 +03:00 by kerem · 0 comments

kerem commented

2026-03-17 00:46:01 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hoppscotch/hoppscotch/pull/1183
Author: @moulik-deepsource
Created: 9/23/2020
Status: ✅ Merged
Merged: 9/24/2020
Merged by: @liyasthomas

Base: refactor ← Head: master

📝 Commits (6)

f723d69 Add .deepsource.toml
69f34fc Update .deepsource.toml
aecaf35 Require default value for props
f1182a9 Found unnecessary semicolons.
5d8cd35 Object.prototypes builtins should not be used directly
c13b377 Require type definitions in props

📊 Changes

14 files changed (+31 additions, -13 deletions)

View changed files

➕ .deepsource.toml (+13 -0)
📝 build.js (+1 -1)
📝 components/collections/import-export-collections.vue (+2 -2)
📝 components/graphql/queryeditor.vue (+1 -0)
📝 components/layout/pw-header.vue (+1 -1)
📝 components/settings/swatch.vue (+1 -0)
📝 components/ui/ace-editor.vue (+1 -0)
📝 components/ui/js-editor.vue (+1 -0)
📝 components/ui/tab.vue (+3 -2)
📝 components/ui/url-field.vue (+1 -1)
📝 helpers/postwomanTesting.js (+1 -1)
📝 layouts/default.vue (+1 -1)
📝 pages/index.vue (+1 -1)
📝 store/postwoman.js (+3 -3)

📄 Description

This pull request fixes some of the issues raised by DeepSource on my fork of this repo.

This PR also contains a .deepsource.toml, in case you want to run continuous quality analyses on your repository. If you wish to do so, you can follow these steps:

Merge this PR.
Signup on DeepSource here.
Activate analysis on your repo.

If you don't want to use DeepSource, I can edit the PR to remove the .deepsource.toml file.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hoppscotch/hoppscotch/pull/1183 **Author:** [@moulik-deepsource](https://github.com/moulik-deepsource) **Created:** 9/23/2020 **Status:** ✅ Merged **Merged:** 9/24/2020 **Merged by:** [@liyasthomas](https://github.com/liyasthomas) **Base:** `refactor` ← **Head:** `master` --- ### 📝 Commits (6) - [`f723d69`](https://github.com/hoppscotch/hoppscotch/commit/f723d69fdbe68107ecc55131663583954eb17e75) Add .deepsource.toml - [`69f34fc`](https://github.com/hoppscotch/hoppscotch/commit/69f34fc029e8bb7511898ae91108be9ac17dc47b) Update .deepsource.toml - [`aecaf35`](https://github.com/hoppscotch/hoppscotch/commit/aecaf35bb8ba84438096abbc8e34d58b136d09e5) Require default value for props - [`f1182a9`](https://github.com/hoppscotch/hoppscotch/commit/f1182a97831afb993dfa6b5b8682cd8441ca429d) Found unnecessary semicolons. - [`5d8cd35`](https://github.com/hoppscotch/hoppscotch/commit/5d8cd35ae7a0f5b2470b0998a1914e6296987966) Object.prototypes builtins should not be used directly - [`c13b377`](https://github.com/hoppscotch/hoppscotch/commit/c13b37781cac93518318f05f961db3493b2f3ae7) Require type definitions in props ### 📊 Changes **14 files changed** (+31 additions, -13 deletions) <details> <summary>View changed files</summary> ➕ `.deepsource.toml` (+13 -0) 📝 `build.js` (+1 -1) 📝 `components/collections/import-export-collections.vue` (+2 -2) 📝 `components/graphql/queryeditor.vue` (+1 -0) 📝 `components/layout/pw-header.vue` (+1 -1) 📝 `components/settings/swatch.vue` (+1 -0) 📝 `components/ui/ace-editor.vue` (+1 -0) 📝 `components/ui/js-editor.vue` (+1 -0) 📝 `components/ui/tab.vue` (+3 -2) 📝 `components/ui/url-field.vue` (+1 -1) 📝 `helpers/postwomanTesting.js` (+1 -1) 📝 `layouts/default.vue` (+1 -1) 📝 `pages/index.vue` (+1 -1) 📝 `store/postwoman.js` (+3 -3) </details> ### 📄 Description This pull request fixes some of the issues raised by [DeepSource](https://deepsource.io/gh/moulik-deepsource/hoppscotch/) on my fork of this repo. This PR also contains a .deepsource.toml, in case you want to run continuous quality analyses on your repository. If you wish to do so, you can follow these steps: Merge this PR. Signup on DeepSource [here](https://deepsource.io/signup/). Activate analysis on your repo. If you don't want to use DeepSource, I can edit the PR to remove the .deepsource.toml file. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>