[PR #1060] [CLOSED] [wip] switching from material icon-font to svg #3037

Closed
opened 2026-03-17 00:41:24 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/hoppscotch/hoppscotch/pull/1060
Author: @ghost
Created: 8/8/2020
Status: Closed

Base: masterHead: master


📝 Commits (6)

  • cca5c1a switching from material font to svg (part 1)
  • 62f9b0e added material icons in SVGs
  • e90a319 added icon.vue component
  • 5486678 limit icons to used only
  • 02c7392 trying :icon instead
  • 7920892 added missing svg icons

📊 Changes

135 files changed (+598 additions, -329 deletions)

View changed files

📝 assets/css/fonts.scss (+1 -14)
📝 assets/css/styles.scss (+5 -2)
assets/icons/access_time.svg (+5 -0)
assets/icons/account_circle.svg (+3 -0)
assets/icons/add.svg (+4 -0)
assets/icons/arrow_drop_down.svg (+4 -0)
assets/icons/arrow_right.svg (+1 -0)
assets/icons/assignment_returned.svg (+4 -0)
assets/icons/assistant.svg (+4 -0)
assets/icons/attach_file.svg (+4 -0)
assets/icons/brush.svg (+4 -0)
assets/icons/chrome.svg (+5 -0)
assets/icons/clear.svg (+3 -0)
assets/icons/clear_all.svg (+3 -0)
assets/icons/close.svg (+3 -0)
assets/icons/cloud.svg (+3 -0)
assets/icons/cloud_download.svg (+3 -0)
assets/icons/cloud_upload.svg (+4 -0)
assets/icons/code.svg (+3 -0)
assets/icons/content_copy.svg (+4 -0)

...and 80 more files

📄 Description

progress:

  1. added <icon icon="some_icon_id"> component
  2. replaced all <i>s with <icon>
  3. added all used material icons in svg (including some missing in official github repo, and only available on md-website)
  4. converted inlined svg into svg files (except for logo)
  5. [currently] figuring out why <icon> component not rendering lmao

This PR fixes #1025


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/hoppscotch/hoppscotch/pull/1060 **Author:** [@ghost](https://github.com/ghost) **Created:** 8/8/2020 **Status:** ❌ Closed **Base:** `master` ← **Head:** `master` --- ### 📝 Commits (6) - [`cca5c1a`](https://github.com/hoppscotch/hoppscotch/commit/cca5c1ae7adee3e188c48b3a605228e603cd2e6b) switching from material font to svg (part 1) - [`62f9b0e`](https://github.com/hoppscotch/hoppscotch/commit/62f9b0e7da2836521d37a95ac4bef7dd5bcd8c66) added material icons in SVGs - [`e90a319`](https://github.com/hoppscotch/hoppscotch/commit/e90a31948fddba8e8248905c28fafa715d24a0f8) added icon.vue component - [`5486678`](https://github.com/hoppscotch/hoppscotch/commit/5486678d23832dd90f54c31a0aa5f768bb2891c8) limit icons to used only - [`02c7392`](https://github.com/hoppscotch/hoppscotch/commit/02c7392ea045cf002e1cae247c27baa0f5882bdc) trying :icon instead - [`7920892`](https://github.com/hoppscotch/hoppscotch/commit/7920892c6a46df9ec17d45a0beccc7dca5e671cc) added missing svg icons ### 📊 Changes **135 files changed** (+598 additions, -329 deletions) <details> <summary>View changed files</summary> 📝 `assets/css/fonts.scss` (+1 -14) 📝 `assets/css/styles.scss` (+5 -2) ➕ `assets/icons/access_time.svg` (+5 -0) ➕ `assets/icons/account_circle.svg` (+3 -0) ➕ `assets/icons/add.svg` (+4 -0) ➕ `assets/icons/arrow_drop_down.svg` (+4 -0) ➕ `assets/icons/arrow_right.svg` (+1 -0) ➕ `assets/icons/assignment_returned.svg` (+4 -0) ➕ `assets/icons/assistant.svg` (+4 -0) ➕ `assets/icons/attach_file.svg` (+4 -0) ➕ `assets/icons/brush.svg` (+4 -0) ➕ `assets/icons/chrome.svg` (+5 -0) ➕ `assets/icons/clear.svg` (+3 -0) ➕ `assets/icons/clear_all.svg` (+3 -0) ➕ `assets/icons/close.svg` (+3 -0) ➕ `assets/icons/cloud.svg` (+3 -0) ➕ `assets/icons/cloud_download.svg` (+3 -0) ➕ `assets/icons/cloud_upload.svg` (+4 -0) ➕ `assets/icons/code.svg` (+3 -0) ➕ `assets/icons/content_copy.svg` (+4 -0) _...and 80 more files_ </details> ### 📄 Description progress: 1. added `<icon icon="some_icon_id">` component 2. replaced all `<i>`s with `<icon>` 3. added ~~all~~ used material icons in svg (including some missing in official github repo, and only available on md-website) 4. converted inlined svg into svg files (except for logo) 5. [currently] figuring out why `<icon>` component not rendering lmao This PR fixes #1025 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-03-17 00:41:24 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/hoppscotch#3037
No description provided.