[PR #1040] [MERGED] Basic linting for JS code #3022

New issue

Closed

opened 2026-03-17 00:40:35 +03:00 by kerem · 0 comments

kerem commented

2026-03-17 00:40:35 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hoppscotch/hoppscotch/pull/1040
Author: @AndrewBastin
Created: 8/2/2020
Status: ✅ Merged
Merged: 8/2/2020
Merged by: @AndrewBastin

Base: master ← Head: feat/js-linting

📝 Commits (5)

b1d3fa3 Handled error handling to pre-request script execution
da9e599 Added esprima as dependency
ec99b48 Added JS linting to Ace Editor
3c3e8a6 Move JS linting code to separate component
45f1e38 PreReq scripts and Test scripts now use JSEditor

📊 Changes

4 files changed (+167 additions, -17 deletions)

View changed files

➕ components/ui/js-editor.vue (+147 -0)
📝 helpers/preRequest.js (+15 -13)
📝 package.json (+1 -0)
📝 pages/index.vue (+4 -4)

📄 Description

This PR intends to add basic syntax linting for JavaScript code (Pre-req scripts and Test scripts) with some help from Esprima.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hoppscotch/hoppscotch/pull/1040 **Author:** [@AndrewBastin](https://github.com/AndrewBastin) **Created:** 8/2/2020 **Status:** ✅ Merged **Merged:** 8/2/2020 **Merged by:** [@AndrewBastin](https://github.com/AndrewBastin) **Base:** `master` ← **Head:** `feat/js-linting` --- ### 📝 Commits (5) - [`b1d3fa3`](https://github.com/hoppscotch/hoppscotch/commit/b1d3fa3f42ff424f246543c0a24e7ee5296bc208) Handled error handling to pre-request script execution - [`da9e599`](https://github.com/hoppscotch/hoppscotch/commit/da9e599e8f9f5c704667ddf12f7262abecaf6839) Added esprima as dependency - [`ec99b48`](https://github.com/hoppscotch/hoppscotch/commit/ec99b486052c2045ccfaac9de09c1f87c53c04e4) Added JS linting to Ace Editor - [`3c3e8a6`](https://github.com/hoppscotch/hoppscotch/commit/3c3e8a6c31d56dc42e37b8816372b61cf7fde702) Move JS linting code to separate component - [`45f1e38`](https://github.com/hoppscotch/hoppscotch/commit/45f1e386cc2909109b2a356b926e9e23b3c37ae5) PreReq scripts and Test scripts now use JSEditor ### 📊 Changes **4 files changed** (+167 additions, -17 deletions) <details> <summary>View changed files</summary> ➕ `components/ui/js-editor.vue` (+147 -0) 📝 `helpers/preRequest.js` (+15 -13) 📝 `package.json` (+1 -0) 📝 `pages/index.vue` (+4 -4) </details> ### 📄 Description This PR intends to add basic syntax linting for JavaScript code (Pre-req scripts and Test scripts) with some help from [Esprima](https://github.com/jquery/esprima). --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>