mirror of
https://github.com/hoppscotch/hoppscotch.git
synced 2026-04-26 01:06:00 +03:00
[PR #915] [MERGED] Cancellable Requests #2933
Labels
No labels
CodeDay
a11y
browser limited
bug
bug fix
cli
core
critical
design
desktop
discussion
docker
documentation
duplicate
enterprise
feature
feature
fosshack
future
good first issue
hacktoberfest
help wanted
i18n
invalid
major
minor
need information
need testing
not applicable to hoppscotch
not reproducible
pull-request
question
refactor
resolved
sandbox
self-host
spam
stale
testmu
wip
wont fix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/hoppscotch#2933
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
📋 Pull Request Information
Original PR: https://github.com/hoppscotch/hoppscotch/pull/915
Author: @AndrewBastin
Created: 5/30/2020
Status: ✅ Merged
Merged: 5/31/2020
Merged by: @AndrewBastin
Base:
master← Head:feat/cancel-button📝 Commits (4)
b2600d3Added cancellable requests for AxiosStrategy62c3b34Added cancellable requests support for ExtensionStrategy0fccd3dAdded cancel request function for network requests4a2f698Added ability to cancel requests📊 Changes
5 files changed (+159 additions, -81 deletions)
View changed files
📝
functions/network.js(+14 -5)📝
functions/strategies/AxiosStrategy.js(+59 -29)📝
functions/strategies/ExtensionStrategy.js(+6 -0)📝
lang/en-US.json(+1 -0)📝
pages/index.vue(+79 -47)📄 Description
This PR intends to add the ability to cancel running requests.
@liyasthomas what do you think about the cancel button ? should it be red or something ?
The browser extensions don't currently support cancellable requests, the cancel attempts will just be ignored in case of extensions for now, the support implementation will be rolled with extension version v0.10 which is a bit delayed as I am waiting for approval for the extension to the Microsoft Edge add-on store.
This PR fixes #909
🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.