[PR #915] [MERGED] Cancellable Requests #2933

Closed
opened 2026-03-17 00:35:42 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/hoppscotch/hoppscotch/pull/915
Author: @AndrewBastin
Created: 5/30/2020
Status: Merged
Merged: 5/31/2020
Merged by: @AndrewBastin

Base: masterHead: feat/cancel-button


📝 Commits (4)

  • b2600d3 Added cancellable requests for AxiosStrategy
  • 62c3b34 Added cancellable requests support for ExtensionStrategy
  • 0fccd3d Added cancel request function for network requests
  • 4a2f698 Added ability to cancel requests

📊 Changes

5 files changed (+159 additions, -81 deletions)

View changed files

📝 functions/network.js (+14 -5)
📝 functions/strategies/AxiosStrategy.js (+59 -29)
📝 functions/strategies/ExtensionStrategy.js (+6 -0)
📝 lang/en-US.json (+1 -0)
📝 pages/index.vue (+79 -47)

📄 Description

This PR intends to add the ability to cancel running requests.

@liyasthomas what do you think about the cancel button ? should it be red or something ?

The browser extensions don't currently support cancellable requests, the cancel attempts will just be ignored in case of extensions for now, the support implementation will be rolled with extension version v0.10 which is a bit delayed as I am waiting for approval for the extension to the Microsoft Edge add-on store.

This PR fixes #909


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/hoppscotch/hoppscotch/pull/915 **Author:** [@AndrewBastin](https://github.com/AndrewBastin) **Created:** 5/30/2020 **Status:** ✅ Merged **Merged:** 5/31/2020 **Merged by:** [@AndrewBastin](https://github.com/AndrewBastin) **Base:** `master` ← **Head:** `feat/cancel-button` --- ### 📝 Commits (4) - [`b2600d3`](https://github.com/hoppscotch/hoppscotch/commit/b2600d3ffdfe245e6f720d7ea1e31f3a51ed45f6) Added cancellable requests for AxiosStrategy - [`62c3b34`](https://github.com/hoppscotch/hoppscotch/commit/62c3b341bb2b07ecf91ab4f843ec558284824a5f) Added cancellable requests support for ExtensionStrategy - [`0fccd3d`](https://github.com/hoppscotch/hoppscotch/commit/0fccd3d5cb7177574aadae3c00cba270eaa5945d) Added cancel request function for network requests - [`4a2f698`](https://github.com/hoppscotch/hoppscotch/commit/4a2f698ff88203035fb2e51093cfe942a9c85943) Added ability to cancel requests ### 📊 Changes **5 files changed** (+159 additions, -81 deletions) <details> <summary>View changed files</summary> 📝 `functions/network.js` (+14 -5) 📝 `functions/strategies/AxiosStrategy.js` (+59 -29) 📝 `functions/strategies/ExtensionStrategy.js` (+6 -0) 📝 `lang/en-US.json` (+1 -0) 📝 `pages/index.vue` (+79 -47) </details> ### 📄 Description This PR intends to add the ability to cancel running requests. @liyasthomas what do you think about the cancel button ? should it be red or something ? The browser extensions don't currently support cancellable requests, the cancel attempts will just be ignored in case of extensions for now, the support implementation will be rolled with extension version v0.10 which is a bit delayed as I am waiting for approval for the extension to the Microsoft Edge add-on store. This PR fixes #909 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-03-17 00:35:42 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/hoppscotch#2933
No description provided.