[PR #876] [MERGED] Make Realtime page URL validations more lenient #2917

Closed
opened 2026-03-17 00:34:53 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/hoppscotch/hoppscotch/pull/876
Author: @AndrewBastin
Created: 5/15/2020
Status: Merged
Merged: 5/15/2020
Merged by: @liyasthomas

Base: masterHead: bugfix/873


📝 Commits (2)

  • b1ffeb1 Updated URL validation regex to be more lenient
  • b49e215 Refactor Realtime URL validation functions

📊 Changes

1 file changed (+9 additions, -19 deletions)

View changed files

📝 functions/utils/valid.js (+9 -19)

📄 Description

This PR intends to update the Realtime page URL validation regexes to be more lenient on its validations as the current one is catching some false negatives.

This PR fixes #873


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/hoppscotch/hoppscotch/pull/876 **Author:** [@AndrewBastin](https://github.com/AndrewBastin) **Created:** 5/15/2020 **Status:** ✅ Merged **Merged:** 5/15/2020 **Merged by:** [@liyasthomas](https://github.com/liyasthomas) **Base:** `master` ← **Head:** `bugfix/873` --- ### 📝 Commits (2) - [`b1ffeb1`](https://github.com/hoppscotch/hoppscotch/commit/b1ffeb1f24b0b840c78210b5155763a2d4f19977) Updated URL validation regex to be more lenient - [`b49e215`](https://github.com/hoppscotch/hoppscotch/commit/b49e215617fc16d63d5795fd9ef6dd1f5794b1e7) Refactor Realtime URL validation functions ### 📊 Changes **1 file changed** (+9 additions, -19 deletions) <details> <summary>View changed files</summary> 📝 `functions/utils/valid.js` (+9 -19) </details> ### 📄 Description This PR intends to update the Realtime page URL validation regexes to be more lenient on its validations as the current one is catching some false negatives. This PR fixes #873 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-03-17 00:34:53 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/hoppscotch#2917
No description provided.