mirror of
https://github.com/hoppscotch/hoppscotch.git
synced 2026-04-25 16:55:59 +03:00
[PR #851] [MERGED] Environment variables in collections #2905
Labels
No labels
CodeDay
a11y
browser limited
bug
bug fix
cli
core
critical
design
desktop
discussion
docker
documentation
duplicate
enterprise
feature
feature
fosshack
future
good first issue
hacktoberfest
help wanted
i18n
invalid
major
minor
need information
need testing
not applicable to hoppscotch
not reproducible
pull-request
question
refactor
resolved
sandbox
self-host
spam
stale
testmu
wip
wont fix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/hoppscotch#2905
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
📋 Pull Request Information
Original PR: https://github.com/hoppscotch/hoppscotch/pull/851
Author: @sboulema
Created: 5/7/2020
Status: ✅ Merged
Merged: 5/9/2020
Merged by: @liyasthomas
Base:
master← Head:feature/environment-variables-in-collections-#642📝 Commits (4)
8b961fbEnvironment variables in collections #6427c945a6Merge branch 'master' into feature/environment-variables-in-collections-#642ab6de36Merge branch 'master' into feature/environment-variables-in-collections-#642c655d55Always save non replaced uri, but display replaced url in the UI📊 Changes
2 files changed (+22 additions, -12 deletions)
View changed files
➕
functions/utils/uri.js(+13 -0)📝
pages/index.vue(+9 -12)📄 Description
Fixes saving a request when using environment variables.
url and path variables get overwritten with replaced values, so before saving we reconstruct them using the original uri variable.
This PR intends to fix #642.
🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.