[PR #851] [MERGED] Environment variables in collections #2905

Closed
opened 2026-03-17 00:34:05 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/hoppscotch/hoppscotch/pull/851
Author: @sboulema
Created: 5/7/2020
Status: Merged
Merged: 5/9/2020
Merged by: @liyasthomas

Base: masterHead: feature/environment-variables-in-collections-#642


📝 Commits (4)

📊 Changes

2 files changed (+22 additions, -12 deletions)

View changed files

functions/utils/uri.js (+13 -0)
📝 pages/index.vue (+9 -12)

📄 Description

Fixes saving a request when using environment variables.

url and path variables get overwritten with replaced values, so before saving we reconstruct them using the original uri variable.

This PR intends to fix #642.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/hoppscotch/hoppscotch/pull/851 **Author:** [@sboulema](https://github.com/sboulema) **Created:** 5/7/2020 **Status:** ✅ Merged **Merged:** 5/9/2020 **Merged by:** [@liyasthomas](https://github.com/liyasthomas) **Base:** `master` ← **Head:** `feature/environment-variables-in-collections-#642` --- ### 📝 Commits (4) - [`8b961fb`](https://github.com/hoppscotch/hoppscotch/commit/8b961fb8cdd88e61d1df1346ddfd4e3d16f83b7f) Environment variables in collections #642 - [`7c945a6`](https://github.com/hoppscotch/hoppscotch/commit/7c945a674d8fcc1aad3e1f4d3827af03d6b128ff) Merge branch 'master' into feature/environment-variables-in-collections-#642 - [`ab6de36`](https://github.com/hoppscotch/hoppscotch/commit/ab6de361abf4290b5d8824b5a65c6809d63d9097) Merge branch 'master' into feature/environment-variables-in-collections-#642 - [`c655d55`](https://github.com/hoppscotch/hoppscotch/commit/c655d551979e2e068b5234933a20138c5ea64215) Always save non replaced uri, but display replaced url in the UI ### 📊 Changes **2 files changed** (+22 additions, -12 deletions) <details> <summary>View changed files</summary> ➕ `functions/utils/uri.js` (+13 -0) 📝 `pages/index.vue` (+9 -12) </details> ### 📄 Description Fixes saving a request when using environment variables. url and path variables get overwritten with replaced values, so before saving we reconstruct them using the original uri variable. This PR intends to fix #642. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-03-17 00:34:05 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/hoppscotch#2905
No description provided.