mirror of
https://github.com/hoppscotch/hoppscotch.git
synced 2026-04-26 01:06:00 +03:00
[PR #820] [MERGED] Realtime SocketIO support for json user input #2877
Labels
No labels
CodeDay
a11y
browser limited
bug
bug fix
cli
core
critical
design
desktop
discussion
docker
documentation
duplicate
enterprise
feature
feature
fosshack
future
good first issue
hacktoberfest
help wanted
i18n
invalid
major
minor
need information
need testing
not applicable to hoppscotch
not reproducible
pull-request
question
refactor
resolved
sandbox
self-host
spam
stale
testmu
wip
wont fix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/hoppscotch#2877
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
📋 Pull Request Information
Original PR: https://github.com/hoppscotch/hoppscotch/pull/820
Author: @feydan
Created: 4/28/2020
Status: ✅ Merged
Merged: 4/28/2020
Merged by: @liyasthomas
Base:
master← Head:socketio-json-support📝 Commits (1)
266cb83Trying to json parse user input so that the socket io library can properly emit json data. Falls back to string input📊 Changes
1 file changed (+12 additions, -6 deletions)
View changed files
📝
components/realtime/socketio.vue(+12 -6)📄 Description
The SocketIo tab in realtime currently only supports string input even though the SocketIo library can support sending json data (implicitly encoding and decoding).
This change attempts to parse the user input to json in order to send it as json instead of a string. If the user input is not valid json, it will be sent as a string.
🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.