[PR #795] [MERGED] Listen to all events in socket.io connection #2864

Closed
opened 2026-03-17 00:31:54 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/hoppscotch/hoppscotch/pull/795
Author: @konradkalemba
Created: 4/20/2020
Status: Merged
Merged: 4/21/2020
Merged by: @liyasthomas

Base: masterHead: master


📝 Commits (1)

  • b89a1cd Listen to all events in socket.io connection

📊 Changes

3 files changed (+14516 additions, -14506 deletions)

View changed files

📝 components/realtime/socketio.vue (+6 -2)
📝 package-lock.json (+14509 -14504)
📝 package.json (+1 -0)

📄 Description

Currently socket.io listens only to message event which isn't ideal - I mentioned this problem in #611. This PR makes a socket.io connection listen to all emitted events.

image


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/hoppscotch/hoppscotch/pull/795 **Author:** [@konradkalemba](https://github.com/konradkalemba) **Created:** 4/20/2020 **Status:** ✅ Merged **Merged:** 4/21/2020 **Merged by:** [@liyasthomas](https://github.com/liyasthomas) **Base:** `master` ← **Head:** `master` --- ### 📝 Commits (1) - [`b89a1cd`](https://github.com/hoppscotch/hoppscotch/commit/b89a1cd06676214341259554dfac8acb2b63df26) Listen to all events in socket.io connection ### 📊 Changes **3 files changed** (+14516 additions, -14506 deletions) <details> <summary>View changed files</summary> 📝 `components/realtime/socketio.vue` (+6 -2) 📝 `package-lock.json` (+14509 -14504) 📝 `package.json` (+1 -0) </details> ### 📄 Description Currently socket.io listens only to `message` event which isn't ideal - I mentioned this problem in #611. This PR makes a socket.io connection listen to all emitted events. ![image](https://user-images.githubusercontent.com/8682104/79788008-3a774380-8348-11ea-8a7d-a1284f3e76e8.png) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-03-17 00:31:54 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/hoppscotch#2864
No description provided.