[PR #681] [MERGED] Fix setting default raw params #2788

New issue

Closed

opened 2026-03-17 00:27:50 +03:00 by kerem · 0 comments

kerem commented

2026-03-17 00:27:50 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hoppscotch/hoppscotch/pull/681
Author: @leomp12
Created: 3/17/2020
Status: ✅ Merged
Merged: 3/17/2020
Merged by: @liyasthomas

Base: master ← Head: fix/raw-params

📝 Commits (2)

b0c3278 Merge pull request #1 from liyasthomas/master
f2c3bd5 fix(raw-params): syntax fix, set default only when params is empty or old default

📊 Changes

1 file changed (+15 additions, -17 deletions)

View changed files

📝 pages/index.vue (+15 -17)

📄 Description

My first PR comes with a minor bug here https://github.com/liyasthomas/postwoman/pull/678/files#diff-b19fa22add3de9cd0b98b05366479d92R1442 😞
It's always true, so every time content type is changed to application/json body will be reset.

I'm fixing it here and also ensuring body is being reset to defaults only if it was not manually changed (empty or equals to default body for old content type).

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hoppscotch/hoppscotch/pull/681 **Author:** [@leomp12](https://github.com/leomp12) **Created:** 3/17/2020 **Status:** ✅ Merged **Merged:** 3/17/2020 **Merged by:** [@liyasthomas](https://github.com/liyasthomas) **Base:** `master` ← **Head:** `fix/raw-params` --- ### 📝 Commits (2) - [`b0c3278`](https://github.com/hoppscotch/hoppscotch/commit/b0c327854c76f7a69ea513293f4bf4b0a81d5670) Merge pull request #1 from liyasthomas/master - [`f2c3bd5`](https://github.com/hoppscotch/hoppscotch/commit/f2c3bd54d66f46a24ce3b442a6b90373c8093ac5) fix(raw-params): syntax fix, set default only when params is empty or old default ### 📊 Changes **1 file changed** (+15 additions, -17 deletions) <details> <summary>View changed files</summary> 📝 `pages/index.vue` (+15 -17) </details> ### 📄 Description My first PR comes with a minor bug here https://github.com/liyasthomas/postwoman/pull/678/files#diff-b19fa22add3de9cd0b98b05366479d92R1442 :disappointed: It's always true, so every time content type is changed to `application/json` body will be reset. I'm fixing it here and also ensuring body is being reset to defaults only if it was not manually changed (empty or equals to default body for old content type). --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>