[PR #559] [MERGED] chore: use typeof as an operator and make use of localizable strings #2703

Closed
opened 2026-03-17 00:23:02 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/hoppscotch/hoppscotch/pull/559
Author: @jamesgeorge007
Created: 2/7/2020
Status: Merged
Merged: 2/7/2020
Merged by: @jamesgeorge007

Base: masterHead: tweaks


📝 Commits (4)

  • 8b00bb5 refactor: use typeof as an operator
  • a351abd refactor: use typeof as an operator
  • 6037dae refactor: use localizable string
  • 6575d03 refactor: use localizable string

📊 Changes

5 files changed (+5 additions, -4 deletions)

View changed files

📝 components/collections/addCollection.vue (+1 -1)
📝 components/collections/editCollection.vue (+1 -1)
📝 functions/network.js (+1 -1)
📝 lang/en-US.js (+1 -0)
📝 pages/settings.vue (+1 -1)

📄 Description

Follow up of #551

  • Use typeof as an operator to ensure consistency across the codebase.
  • Replace hard-coded strings with localizable strings.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/hoppscotch/hoppscotch/pull/559 **Author:** [@jamesgeorge007](https://github.com/jamesgeorge007) **Created:** 2/7/2020 **Status:** ✅ Merged **Merged:** 2/7/2020 **Merged by:** [@jamesgeorge007](https://github.com/jamesgeorge007) **Base:** `master` ← **Head:** `tweaks` --- ### 📝 Commits (4) - [`8b00bb5`](https://github.com/hoppscotch/hoppscotch/commit/8b00bb59de30b0dec65649df7772d5961beb1a29) refactor: use typeof as an operator - [`a351abd`](https://github.com/hoppscotch/hoppscotch/commit/a351abd5d9ba2493c697ef10afcf5ea11c7eccd1) refactor: use typeof as an operator - [`6037dae`](https://github.com/hoppscotch/hoppscotch/commit/6037daedcd936c5461deb407af6ccde122da5972) refactor: use localizable string - [`6575d03`](https://github.com/hoppscotch/hoppscotch/commit/6575d03f45a99ffc5b351b6a5d9c0882a64f824d) refactor: use localizable string ### 📊 Changes **5 files changed** (+5 additions, -4 deletions) <details> <summary>View changed files</summary> 📝 `components/collections/addCollection.vue` (+1 -1) 📝 `components/collections/editCollection.vue` (+1 -1) 📝 `functions/network.js` (+1 -1) 📝 `lang/en-US.js` (+1 -0) 📝 `pages/settings.vue` (+1 -1) </details> ### 📄 Description Follow up of #551 - Use `typeof` as an operator to ensure consistency across the codebase. - Replace hard-coded strings with localizable strings. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-03-17 00:23:02 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/hoppscotch#2703
No description provided.