mirror of
https://github.com/hoppscotch/hoppscotch.git
synced 2026-04-26 09:16:03 +03:00
[PR #550] [MERGED] Refactor Type Error in Collections Dir #2699
Labels
No labels
CodeDay
a11y
browser limited
bug
bug fix
cli
core
critical
design
desktop
discussion
docker
documentation
duplicate
enterprise
feature
feature
fosshack
future
good first issue
hacktoberfest
help wanted
i18n
invalid
major
minor
need information
need testing
not applicable to hoppscotch
not reproducible
pull-request
question
refactor
resolved
sandbox
self-host
spam
stale
testmu
wip
wont fix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/hoppscotch#2699
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
📋 Pull Request Information
Original PR: https://github.com/hoppscotch/hoppscotch/pull/550
Author: @Sn005
Created: 2/4/2020
Status: ✅ Merged
Merged: 2/5/2020
Merged by: @AndrewBastin
Base:
typescript← Head:refactor_typeerror_in_collections_dir📝 Commits (7)
f3c9eb9refactor type error & type any1752601create types file for collections/*.vue81561d1mod import Request type and update props5bf41efmod import Folder type and update props0344761mod import Folder,Collection type and update propseb51056Add Type definition6e19b18remove type any📊 Changes
8 files changed (+76 additions, -111 deletions)
View changed files
📝
components/collections/collection.vue(+5 -8)📝
components/collections/editFolder.vue(+7 -15)📝
components/collections/editRequest.vue(+14 -30)📝
components/collections/folder.vue(+4 -3)📝
components/collections/importExportCollections.vue(+16 -16)📝
components/collections/request.vue(+3 -2)📝
components/collections/saveRequestAs.vue(+13 -37)➕
components/collections/types.ts(+14 -0)📄 Description
This PR deletes type errors and type any in
components/collectionsdirectory.Supplement
Type refactoring work in other directories will be done in another PR.
🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.