[PR #513] [MERGED] Auth #2669

New issue

Closed

opened 2026-03-17 00:21:08 +03:00 by kerem · 0 comments

kerem commented

2026-03-17 00:21:08 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hoppscotch/hoppscotch/pull/513
Author: @liyasthomas
Created: 1/22/2020
Status: ✅ Merged
Merged: 1/23/2020
Merged by: @liyasthomas

Base: master ← Head: auth

📝 Commits (10+)

8ae5dbc Fixed proxying through the firefox extension
fb4554a 🎉 Initial Auth
19a2323 ♻️ Lint
c7e5fc4 ✨ Moved inputform and feed to index
a852432 🎨 Minor UI stylings
29e96dd ✨ Delete data
8bc1df9 ✨ Show logged in user image
01a890b ♻️ Refactor
40e05a0 ✨ Account setting on setting page
43d95a2 ✏️ Typo

📊 Changes

21 files changed (+1821 additions, -55 deletions)

View changed files

📝 README.md (+5 -3)
📝 assets/css/fonts.scss (+1 -0)
📝 assets/css/styles.scss (+1 -0)
📝 components/collections/addCollection.vue (+4 -0)
📝 components/collections/editCollection.vue (+4 -0)
➕ components/firebase/feeds.vue (+85 -0)
➕ components/firebase/inputform.vue (+55 -0)
➕ components/firebase/login.vue (+115 -0)
📝 components/history.vue (+15 -4)
📝 firestore.rules (+8 -1)
➕ functions/fb.js (+165 -0)
📝 functions/network.js (+6 -1)
➕ functions/strategies/ChromeStrategy.js (+56 -0)
📝 functions/strategies/FirefoxStrategy.js (+1 -1)
📝 lang/en-US.js (+11 -1)
📝 layouts/default.vue (+96 -24)
📝 package-lock.json (+979 -15)
📝 package.json (+2 -0)
📝 pages/index.vue (+37 -4)
📝 pages/settings.vue (+169 -1)

...and 1 more files

📄 Description

Auth is ready for testing 🎉

Sign-in with Google
Sign-in with GitHub
Firestore integration
Account section in "Settings page"
UI
Manual CRUD operation
Permissions
History sync
Testing

Preview deploy: https://deploy-preview-513--postwoman.netlify.com

Flow:

"Login with" button on top-right button
Select any one-time Auth provider (Google, GitHub)
Sign-in (OAuth id)
One time Toast prompt to "Turn on sync" or Enable from "Settings page"
Manual CRUD: Home page > Sidebar > Sync

fixes #514
fixes #507
fixes #26

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hoppscotch/hoppscotch/pull/513 **Author:** [@liyasthomas](https://github.com/liyasthomas) **Created:** 1/22/2020 **Status:** ✅ Merged **Merged:** 1/23/2020 **Merged by:** [@liyasthomas](https://github.com/liyasthomas) **Base:** `master` ← **Head:** `auth` --- ### 📝 Commits (10+) - [`8ae5dbc`](https://github.com/hoppscotch/hoppscotch/commit/8ae5dbc3750b9576e924d28b444e42288ce6c0af) Fixed proxying through the firefox extension - [`fb4554a`](https://github.com/hoppscotch/hoppscotch/commit/fb4554abe3791272d4082b89f946c1de391ccb51) :tada: Initial Auth - [`19a2323`](https://github.com/hoppscotch/hoppscotch/commit/19a23238802b6fc2eb7d7b9b035b674d898659fc) :recycle: Lint - [`c7e5fc4`](https://github.com/hoppscotch/hoppscotch/commit/c7e5fc47baaff58924300135249d73d6e611bc70) :sparkles: Moved inputform and feed to index - [`a852432`](https://github.com/hoppscotch/hoppscotch/commit/a852432c9f5647ef4e0d25201a0f525e591294b6) :art: Minor UI stylings - [`29e96dd`](https://github.com/hoppscotch/hoppscotch/commit/29e96ddd12af821099545a345288c895a254ec42) ✨ Delete data - [`8bc1df9`](https://github.com/hoppscotch/hoppscotch/commit/8bc1df9b8e813f115f7de258feb28c127e3ad5ca) :sparkles: Show logged in user image - [`01a890b`](https://github.com/hoppscotch/hoppscotch/commit/01a890bce977956af3020be524d41a6425b55875) :recycle: Refactor - [`40e05a0`](https://github.com/hoppscotch/hoppscotch/commit/40e05a04615db2d6339f03f0820471ee0c3e204f) ✨ Account setting on setting page - [`43d95a2`](https://github.com/hoppscotch/hoppscotch/commit/43d95a22712051e8779c7e0acd20741324300281) :pencil2: Typo ### 📊 Changes **21 files changed** (+1821 additions, -55 deletions) <details> <summary>View changed files</summary> 📝 `README.md` (+5 -3) 📝 `assets/css/fonts.scss` (+1 -0) 📝 `assets/css/styles.scss` (+1 -0) 📝 `components/collections/addCollection.vue` (+4 -0) 📝 `components/collections/editCollection.vue` (+4 -0) ➕ `components/firebase/feeds.vue` (+85 -0) ➕ `components/firebase/inputform.vue` (+55 -0) ➕ `components/firebase/login.vue` (+115 -0) 📝 `components/history.vue` (+15 -4) 📝 `firestore.rules` (+8 -1) ➕ `functions/fb.js` (+165 -0) 📝 `functions/network.js` (+6 -1) ➕ `functions/strategies/ChromeStrategy.js` (+56 -0) 📝 `functions/strategies/FirefoxStrategy.js` (+1 -1) 📝 `lang/en-US.js` (+11 -1) 📝 `layouts/default.vue` (+96 -24) 📝 `package-lock.json` (+979 -15) 📝 `package.json` (+2 -0) 📝 `pages/index.vue` (+37 -4) 📝 `pages/settings.vue` (+169 -1) _...and 1 more files_ </details> ### 📄 Description Auth is ready for testing 🎉 - [x] Sign-in with Google - [x] Sign-in with GitHub - [x] Firestore integration - [x] Account section in "Settings page" - [x] UI - [x] Manual CRUD operation - [x] Permissions - [x] History sync - [x] Testing Preview deploy: https://deploy-preview-513--postwoman.netlify.com Flow: 1. "Login with" button on top-right button 2. Select any one-time Auth provider (Google, GitHub) 3. Sign-in (OAuth id) 4. One time Toast prompt to "Turn on sync" or Enable from "Settings page" 5. Manual CRUD: Home page > Sidebar > Sync ![localhost_3000_](https://user-images.githubusercontent.com/10395817/72859816-15dce280-3ceb-11ea-83fc-0ccde125072c.png) ![localhost_3000_settings](https://user-images.githubusercontent.com/10395817/72859828-20977780-3ceb-11ea-8e26-fdf04bf322fb.png) fixes #514 fixes #507 fixes #26 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>