[PR #500] [MERGED] Refactoring proxy handling to be done in strategies #2660

New issue

Closed

opened 2026-03-17 00:20:35 +03:00 by kerem · 0 comments

kerem commented

2026-03-17 00:20:35 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hoppscotch/hoppscotch/pull/500
Author: @AndrewBastin
Created: 1/17/2020
Status: ✅ Merged
Merged: 1/18/2020
Merged by: @AndrewBastin

Base: master ← Head: refactor/strategy-proxy-handling

📝 Commits (10+)

2a51ec6 Moved proxy code to be handled in each strategy
951266e Added proxy support to FirefoxStrategy
a9224b9 Merge branch 'master' into refactor/strategy-proxy-handling
9d085e3 Merge branch 'master' into refactor/strategy-proxy-handling
730018b Improve strategy code redability
c61d825 Merge branch 'refactor/strategy-proxy-handling' of https://github.com/AndrewBastin/postwoman into refactor/strategy-proxy-handling
a1568a9 Update functions/strategies/FirefoxStrategy.js
8e86e4c Update functions/strategies/AxiosStrategy.js
3b96f85 Make James happy by doing proper code refactors
aa056ff refactor: remove extraneous else

📊 Changes

4 files changed (+50 additions, -21 deletions)

View changed files

📝 functions/network.js (+0 -5)
📝 functions/strategies/AxiosStrategy.js (+17 -1)
📝 functions/strategies/FirefoxStrategy.js (+33 -3)
➖ functions/strategies/ProxyStrategy.js (+0 -12)

📄 Description

This PR intends to move the proxy handling code to the individual strategies along with that, this PR introduces Postwoman request proxy support for Firefox Extension powered requests.

NOTE: To test the Firefox extension code, you will have to load the extension locally. The extension that can be downloaded from the Firefox Add-on's page does not hook into localhost pages for security reasons, for more info on how to do that, visit https://github.com/AndrewBastin/postwoman-firefox

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hoppscotch/hoppscotch/pull/500 **Author:** [@AndrewBastin](https://github.com/AndrewBastin) **Created:** 1/17/2020 **Status:** ✅ Merged **Merged:** 1/18/2020 **Merged by:** [@AndrewBastin](https://github.com/AndrewBastin) **Base:** `master` ← **Head:** `refactor/strategy-proxy-handling` --- ### 📝 Commits (10+) - [`2a51ec6`](https://github.com/hoppscotch/hoppscotch/commit/2a51ec6d9f410a5b784efb09dd7a6468cbecee34) Moved proxy code to be handled in each strategy - [`951266e`](https://github.com/hoppscotch/hoppscotch/commit/951266e52946c99a4acf7d8818795a5e5d510562) Added proxy support to FirefoxStrategy - [`a9224b9`](https://github.com/hoppscotch/hoppscotch/commit/a9224b94b193bc2566f594470947b950e711166d) Merge branch 'master' into refactor/strategy-proxy-handling - [`9d085e3`](https://github.com/hoppscotch/hoppscotch/commit/9d085e301d88e780d85a278656743804a112ac2d) Merge branch 'master' into refactor/strategy-proxy-handling - [`730018b`](https://github.com/hoppscotch/hoppscotch/commit/730018b45ff8036955b301eff81dc4753b07641c) Improve strategy code redability - [`c61d825`](https://github.com/hoppscotch/hoppscotch/commit/c61d825c3797cebd2339e9428b6104f64d4f3461) Merge branch 'refactor/strategy-proxy-handling' of https://github.com/AndrewBastin/postwoman into refactor/strategy-proxy-handling - [`a1568a9`](https://github.com/hoppscotch/hoppscotch/commit/a1568a98d4cbba0959affb9336bf4db8306bbfcf) Update functions/strategies/FirefoxStrategy.js - [`8e86e4c`](https://github.com/hoppscotch/hoppscotch/commit/8e86e4c8e8d02fcce35f844b0f586ae163e181d4) Update functions/strategies/AxiosStrategy.js - [`3b96f85`](https://github.com/hoppscotch/hoppscotch/commit/3b96f85c55490f5f5312b43a6dec9f84cf8040fa) Make James happy by doing proper code refactors - [`aa056ff`](https://github.com/hoppscotch/hoppscotch/commit/aa056ff1c159cc971a506cb4e1917a30afc67aa9) refactor: remove extraneous else ### 📊 Changes **4 files changed** (+50 additions, -21 deletions) <details> <summary>View changed files</summary> 📝 `functions/network.js` (+0 -5) 📝 `functions/strategies/AxiosStrategy.js` (+17 -1) 📝 `functions/strategies/FirefoxStrategy.js` (+33 -3) ➖ `functions/strategies/ProxyStrategy.js` (+0 -12) </details> ### 📄 Description This PR intends to move the proxy handling code to the individual strategies along with that, this PR introduces Postwoman request proxy support for Firefox Extension powered requests. *NOTE: To test the Firefox extension code, you will have to load the extension locally. The extension that can be downloaded from the Firefox Add-on's page does not hook into localhost pages for security reasons, for more info on how to do that, visit [https://github.com/AndrewBastin/postwoman-firefox](https://github.com/AndrewBastin/postwoman-firefox)* --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>