[PR #432] [MERGED] chore: stick to Vue.js best practices #2623

Closed
opened 2026-03-17 00:18:40 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/hoppscotch/hoppscotch/pull/432
Author: @jamesgeorge007
Created: 12/15/2019
Status: Merged
Merged: 12/15/2019
Merged by: @liyasthomas

Base: masterHead: refactor/enhancements


📝 Commits (10+)

  • 4c82ef8 refactor: make component tag self closing
  • fcc6f5a refactor: make history component self closing
  • 82096f3 refactor: use property shorthand for consistency
  • b20cb04 refactor: make collection component self closing
  • f49bfb4 refactor: use property shorthand for consistency
  • 998a925 refactor: make request component self closing
  • 9223044 refactor: use property shorthand for consistency
  • 0791d19 refactor: use property shorthand for consistency
  • 928ace5 refactor: use property shorthand for consistency
  • 48bd772 refactor: make use of v-bind directive shorthand

📊 Changes

8 files changed (+57 additions, -57 deletions)

View changed files

📝 components/collections/collection.vue (+11 -11)
📝 components/collections/editCollection.vue (+1 -1)
📝 components/collections/editFolder.vue (+1 -1)
📝 components/collections/folder.vue (+5 -5)
📝 components/collections/index.vue (+31 -31)
📝 components/collections/saveRequestAs.vue (+1 -1)
📝 layouts/default.vue (+2 -2)
📝 pages/index.vue (+5 -5)

📄 Description

  • Self closing components.
  • Use directive short-hands across the code-base for consistency.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/hoppscotch/hoppscotch/pull/432 **Author:** [@jamesgeorge007](https://github.com/jamesgeorge007) **Created:** 12/15/2019 **Status:** ✅ Merged **Merged:** 12/15/2019 **Merged by:** [@liyasthomas](https://github.com/liyasthomas) **Base:** `master` ← **Head:** `refactor/enhancements` --- ### 📝 Commits (10+) - [`4c82ef8`](https://github.com/hoppscotch/hoppscotch/commit/4c82ef89fbcb71376d9209747146963574c18506) refactor: make component tag self closing - [`fcc6f5a`](https://github.com/hoppscotch/hoppscotch/commit/fcc6f5aa76895422a1ca18d0c0509467dd9a9f3a) refactor: make history component self closing - [`82096f3`](https://github.com/hoppscotch/hoppscotch/commit/82096f3a1eb53157dd836e7d6462a74daaa24189) refactor: use property shorthand for consistency - [`b20cb04`](https://github.com/hoppscotch/hoppscotch/commit/b20cb040b084d621034008274c5474d54a6e0c9e) refactor: make collection component self closing - [`f49bfb4`](https://github.com/hoppscotch/hoppscotch/commit/f49bfb4d74ebb41f5fafb62ad0cae52f53b6d15a) refactor: use property shorthand for consistency - [`998a925`](https://github.com/hoppscotch/hoppscotch/commit/998a925fd1aeb4788cb52644f56134086afa27a9) refactor: make request component self closing - [`9223044`](https://github.com/hoppscotch/hoppscotch/commit/9223044967625fc8ea523b9a1c0a7ef11dfa1a6b) refactor: use property shorthand for consistency - [`0791d19`](https://github.com/hoppscotch/hoppscotch/commit/0791d196d44de936be9e553fe33acbe051fc9baa) refactor: use property shorthand for consistency - [`928ace5`](https://github.com/hoppscotch/hoppscotch/commit/928ace5ba67614ef48bd53f48eb87acdb0ed7cb4) refactor: use property shorthand for consistency - [`48bd772`](https://github.com/hoppscotch/hoppscotch/commit/48bd772171b1a6c51689ef11d2bf2bcdeac87161) refactor: make use of v-bind directive shorthand ### 📊 Changes **8 files changed** (+57 additions, -57 deletions) <details> <summary>View changed files</summary> 📝 `components/collections/collection.vue` (+11 -11) 📝 `components/collections/editCollection.vue` (+1 -1) 📝 `components/collections/editFolder.vue` (+1 -1) 📝 `components/collections/folder.vue` (+5 -5) 📝 `components/collections/index.vue` (+31 -31) 📝 `components/collections/saveRequestAs.vue` (+1 -1) 📝 `layouts/default.vue` (+2 -2) 📝 `pages/index.vue` (+5 -5) </details> ### 📄 Description - Self closing components. - Use directive short-hands across the code-base for consistency. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-03-17 00:18:40 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/hoppscotch#2623
No description provided.