mirror of
https://github.com/hoppscotch/hoppscotch.git
synced 2026-04-26 01:06:00 +03:00
[PR #331] [CLOSED] Make primary and secondary navs easier to distinguish #2564
Labels
No labels
CodeDay
a11y
browser limited
bug
bug fix
cli
core
critical
design
desktop
discussion
docker
documentation
duplicate
enterprise
feature
feature
fosshack
future
good first issue
hacktoberfest
help wanted
i18n
invalid
major
minor
need information
need testing
not applicable to hoppscotch
not reproducible
pull-request
question
refactor
resolved
sandbox
self-host
spam
stale
testmu
wip
wont fix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/hoppscotch#2564
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
📋 Pull Request Information
Original PR: https://github.com/hoppscotch/hoppscotch/pull/331
Author: @roryokane
Created: 11/24/2019
Status: ❌ Closed
Base:
master← Head:add-nav-spacing📝 Commits (1)
afc5503Make primary and secondary navs easier to distinguish📊 Changes
1 file changed (+2 additions, -0 deletions)
View changed files
📝
assets/css/styles.scss(+2 -0)📄 Description
Add more space between the primary nav (Home, WebSocket, GraphQL, Settings) and the secondary nav (the sections of the current app page, for example Request, Options, and Response).
Background
When I first opened Postwoman and tried to understand the interface, the primary and secondary navs looked like just one big primary nav to me. I clicked on each primary nav item one by one to explore, and I only noticed that secondary nav items worked differently when I clicked on one and it didn’t take me to a new page. There is a tiny dividing line between the navs in the sidebar, but it was so subtle I didn’t see it until after I noticed that the button I clicked had worked differently.
There are many possible ways to make the difference in navs more obvious, such as making the buttons look more different or adding a textual header, but adding spacing seems like a good, simple initial improvement. I chose 16px of extra spacing on each side of the divider because it looked best to my eyes compared to 8px and 12px. 16px is also used in some styles on nearby elements, so it keeps the interface somewhat consistent.
Screenshots
🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.