[PR #292] [MERGED] Replace highlight.js with ace editor. #2540

Closed
opened 2026-03-17 00:14:02 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/hoppscotch/hoppscotch/pull/292
Author: @hosseinnedaee
Created: 11/9/2019
Status: Merged
Merged: 11/12/2019
Merged by: @hosseinnedaee

Base: masterHead: implement-ace-instead-highlightjs


📝 Commits (6)

  • 1a9b4cd Replace highlight.js with ace editor.
  • 4accbda Change ace editor font-family
  • 716434d Reduce response body font size
  • 179010d Change ace-editor theme by PW theme changing.
  • 4ca78a2 Make lang prop dynamic.
  • f9e62f3 Merge branch 'master' into implement-ace-instead-highlightjs

📊 Changes

7 files changed (+150 additions, -52 deletions)

View changed files

📝 assets/css/styles.scss (+8 -3)
components/ace-editor.vue (+85 -0)
📝 package-lock.json (+5 -5)
📝 package.json (+1 -1)
📝 pages/index.vue (+35 -37)
📝 pages/settings.vue (+11 -6)
📝 store/postwoman.js (+5 -0)

📄 Description

In this PR I removed highlight.js and implemented ace editor that support textarea highlighting.

resolving https://github.com/liyasthomas/postwoman/issues/266


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/hoppscotch/hoppscotch/pull/292 **Author:** [@hosseinnedaee](https://github.com/hosseinnedaee) **Created:** 11/9/2019 **Status:** ✅ Merged **Merged:** 11/12/2019 **Merged by:** [@hosseinnedaee](https://github.com/hosseinnedaee) **Base:** `master` ← **Head:** `implement-ace-instead-highlightjs` --- ### 📝 Commits (6) - [`1a9b4cd`](https://github.com/hoppscotch/hoppscotch/commit/1a9b4cdbf5bee94e6282ed1547fc890ff0c383b4) Replace highlight.js with ace editor. - [`4accbda`](https://github.com/hoppscotch/hoppscotch/commit/4accbda49785622f943ba3888915b13f02191c37) Change ace editor font-family - [`716434d`](https://github.com/hoppscotch/hoppscotch/commit/716434d59ed4387b2549eba20f5d9f91e89b0ffe) Reduce response body font size - [`179010d`](https://github.com/hoppscotch/hoppscotch/commit/179010ddbff1ec7ab13b67e369805d545cf187bf) Change ace-editor theme by PW theme changing. - [`4ca78a2`](https://github.com/hoppscotch/hoppscotch/commit/4ca78a2fe55d145125d703d05d6fed2202b5f7ae) Make `lang` prop dynamic. - [`f9e62f3`](https://github.com/hoppscotch/hoppscotch/commit/f9e62f32372e4a60e48fc6a4ca6740ddf38e001c) Merge branch 'master' into implement-ace-instead-highlightjs ### 📊 Changes **7 files changed** (+150 additions, -52 deletions) <details> <summary>View changed files</summary> 📝 `assets/css/styles.scss` (+8 -3) ➕ `components/ace-editor.vue` (+85 -0) 📝 `package-lock.json` (+5 -5) 📝 `package.json` (+1 -1) 📝 `pages/index.vue` (+35 -37) 📝 `pages/settings.vue` (+11 -6) 📝 `store/postwoman.js` (+5 -0) </details> ### 📄 Description In this PR I removed highlight.js and implemented ace editor that support textarea highlighting. resolving https://github.com/liyasthomas/postwoman/issues/266 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-03-17 00:14:02 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/hoppscotch#2540
No description provided.