[PR #216] [MERGED] Fixed frame colors toggle #2490

New issue

Closed

opened 2026-03-17 00:11:18 +03:00 by kerem · 0 comments

kerem commented

2026-03-17 00:11:18 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hoppscotch/hoppscotch/pull/216
Author: @mateusppereira
Created: 10/25/2019
Status: ✅ Merged
Merged: 10/25/2019
Merged by: @NBTX

Base: master ← Head: bug-fix-frame-colors

📝 Commits (3)

2f13546 fixed frame colors bug
2240796 fix mistake
9103cee using toggleSetting method

📊 Changes

3 files changed (+10 additions, -10 deletions)

View changed files

📝 components/section.vue (+3 -3)
📝 pages/settings.vue (+6 -6)
📝 store/postwoman.js (+1 -1)

📄 Description

There is was a bug on frame colors toggle. When you click once the toggle changes.

Change the setting name to FRAME_COLORS_ENABLED to match the pattern and improve readability
Using toggleSetting method for toggle components

To reproduce this bug, just open https://postwoman.io/settings and try to toggle Multi-Color in Frames section

fixed: https://www.loom.com/share/bd598afe32b44cb583fed608ccb50584

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hoppscotch/hoppscotch/pull/216 **Author:** [@mateusppereira](https://github.com/mateusppereira) **Created:** 10/25/2019 **Status:** ✅ Merged **Merged:** 10/25/2019 **Merged by:** [@NBTX](https://github.com/NBTX) **Base:** `master` ← **Head:** `bug-fix-frame-colors` --- ### 📝 Commits (3) - [`2f13546`](https://github.com/hoppscotch/hoppscotch/commit/2f13546b8baebad0f06f894f9fe3b9f4a28b3a4f) fixed frame colors bug - [`2240796`](https://github.com/hoppscotch/hoppscotch/commit/224079674b82c1586e7abe6fd1646dac12ef167e) fix mistake - [`9103cee`](https://github.com/hoppscotch/hoppscotch/commit/9103ceeb1e5f238c14e4e3743201b23a385176a5) using toggleSetting method ### 📊 Changes **3 files changed** (+10 additions, -10 deletions) <details> <summary>View changed files</summary> 📝 `components/section.vue` (+3 -3) 📝 `pages/settings.vue` (+6 -6) 📝 `store/postwoman.js` (+1 -1) </details> ### 📄 Description There ~is~ was a bug on frame colors toggle. When you click once the toggle changes. - Change the setting name to `FRAME_COLORS_ENABLED` to match the pattern and improve readability - Using `toggleSetting` method for toggle components To reproduce this bug, just open https://postwoman.io/settings and try to toggle Multi-Color in Frames section fixed: https://www.loom.com/share/bd598afe32b44cb583fed608ccb50584 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>