mirror of
https://github.com/hoppscotch/hoppscotch.git
synced 2026-04-26 01:06:00 +03:00
[PR #185] [MERGED] Added auto theme #2469
Labels
No labels
CodeDay
a11y
browser limited
bug
bug fix
cli
core
critical
design
desktop
discussion
docker
documentation
duplicate
enterprise
feature
feature
fosshack
future
good first issue
hacktoberfest
help wanted
i18n
invalid
major
minor
need information
need testing
not applicable to hoppscotch
not reproducible
pull-request
question
refactor
resolved
sandbox
self-host
spam
stale
testmu
wip
wont fix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/hoppscotch#2469
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
📋 Pull Request Information
Original PR: https://github.com/hoppscotch/hoppscotch/pull/185
Author: @AndrewBastin
Created: 10/4/2019
Status: ✅ Merged
Merged: 10/5/2019
Merged by: @liyasthomas
Base:
master← Head:master📝 Commits (1)
2f16882Added auto theme📊 Changes
2 files changed (+55 additions, -1 deletions)
View changed files
📝
assets/css/themes.scss(+47 -0)📝
pages/settings.vue(+8 -1)📄 Description
This PR adds an automatic theme which uses the
prefers-color-schememedia query to automatically go to dark mode or be in light mode respecting the user's system's norms (like Android and iOS dark modes, Windows/macOS dark modes (some change based on time of day)).Now, I do kinda feel auto to be a good candidate for being the default theme, since it integrates more with the system preference. So if this can be replaced from dark as the default, please feel free to add to my commit.
🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.