[PR #109] [MERGED] Fix intersection button send #2415

New issue

Closed

opened 2026-03-17 00:07:12 +03:00 by kerem · 0 comments

kerem commented

2026-03-17 00:07:12 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hoppscotch/hoppscotch/pull/109
Author: @guastallaigor
Created: 8/30/2019
Status: ✅ Merged
Merged: 8/30/2019
Merged by: @izerozlu

Base: master ← Head: fix-intersection-button-send

📝 Commits (3)

0c9977a Merge remote-tracking branch 'liyasthomas/master'
4b4e6ca Fix intersection button send again (removed validation inside forEach)
daa491c Change again the way of showing by adding and clearing the className

📊 Changes

1 file changed (+10 additions, -16 deletions)

View changed files

📝 pages/index.vue (+10 -16)

📄 Description

In my opinion something is wrong right now with the button fixed, using the Intersection API (ref #107 #94). At my environment, it only works on the first scroll and every two full page scrolls after that.

This PR changes the logic a bit to make it work all the time.

Right now:

After this PR:

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hoppscotch/hoppscotch/pull/109 **Author:** [@guastallaigor](https://github.com/guastallaigor) **Created:** 8/30/2019 **Status:** ✅ Merged **Merged:** 8/30/2019 **Merged by:** [@izerozlu](https://github.com/izerozlu) **Base:** `master` ← **Head:** `fix-intersection-button-send` --- ### 📝 Commits (3) - [`0c9977a`](https://github.com/hoppscotch/hoppscotch/commit/0c9977a92a64b53909e213ea5de6c35d331f76e0) Merge remote-tracking branch 'liyasthomas/master' - [`4b4e6ca`](https://github.com/hoppscotch/hoppscotch/commit/4b4e6ca31a04528710e3b700bca67ed039ce8551) Fix intersection button send again (removed validation inside forEach) - [`daa491c`](https://github.com/hoppscotch/hoppscotch/commit/daa491cd176d425246778c6d3a74bcd7c8094b55) Change again the way of showing by adding and clearing the className ### 📊 Changes **1 file changed** (+10 additions, -16 deletions) <details> <summary>View changed files</summary> 📝 `pages/index.vue` (+10 -16) </details> ### 📄 Description In my opinion something is wrong right now with the button fixed, using the Intersection API (ref #107 #94). At my environment, it only works on the first scroll and every two full page scrolls after that. This PR changes the logic a bit to make it work all the time. **Right now:** ![screencast-liyasthomas github io-2019 08 30-09-31-02](https://user-images.githubusercontent.com/22016005/64021763-104be980-cb0b-11e9-888f-45d49a5ab778.gif) **After this PR:** ![screencast-localhost-3000-2019 08 30-09-35-06](https://user-images.githubusercontent.com/22016005/64021794-22c62300-cb0b-11e9-925c-d3bb76476d53.gif) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>