mirror of
https://github.com/hoppscotch/hoppscotch.git
synced 2026-04-25 16:55:59 +03:00
[GH-ISSUE #57] Request Headers #22
Labels
No labels
CodeDay
a11y
browser limited
bug
bug fix
cli
core
critical
design
desktop
discussion
docker
documentation
duplicate
enterprise
feature
feature
fosshack
future
good first issue
hacktoberfest
help wanted
i18n
invalid
major
minor
need information
need testing
not applicable to hoppscotch
not reproducible
pull-request
question
refactor
resolved
sandbox
self-host
spam
stale
testmu
wip
wont fix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/hoppscotch#22
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @JockDaRock on GitHub (Aug 25, 2019).
Original GitHub issue: https://github.com/hoppscotch/hoppscotch/issues/57
Is your feature request related to a problem? Please describe.
Would like to be able to add custom request headers to requests before sending and control headers that are sent.
Describe the solution you'd like
A section the has request headers where you can control and add headers to be sent with API request
@liyasthomas commented on GitHub (Aug 25, 2019):
That would be great. Lets discuss its scope here and will try to implement it.
@brandonros commented on GitHub (Aug 25, 2019):
One of my biggest gripes with Postman is how it tries to handle the
Cookieheader for you (based off of the Set-Cookie response)It tries to blend its own internal cookie jar with a sometimes explicitly set Cookie header.
I'd say, make the cookie jar functionality an option, therefore allowing the user to "break out" and handle the Cookie header on their own, if needed.
@brandonros commented on GitHub (Aug 25, 2019):
Scope:
UI presents the same UI for "parameters" to manage key value pairs of string (headerName) -> string (header value). Pass them along as request header. Voila. 🎉
Where it gets tricky is.... do you want to support cases where the "key" is not unique? example:
curl -H 'foo: 1' -H 'foo: 2'I don't know why people would ever do this, but I know for darn sure that TypeScript complains if I try to treat a request header in node.js as a string instead of
string | string[].I'd vote no, don't support that. :)
@JacobAnavisca commented on GitHub (Aug 27, 2019):
Just made a pull for this https://github.com/liyasthomas/postwoman/pull/68
Also added orange if that's okay for another color.
@liyasthomas commented on GitHub (Aug 27, 2019):
#68 fixes this issue hence closing