starred/hoppscotch

Fork 0

mirror of https://github.com/hoppscotch/hoppscotch.git synced 2026-04-25 16:55:59 +03:00

[GH-ISSUE #488] Application contains many hard-coded strings that aren't translatable #191

New issue

Closed

opened 2026-03-16 13:58:10 +03:00 by kerem · 6 comments

kerem commented

2026-03-16 13:58:10 +03:00

Owner

Originally created by @alecananian on GitHub (Jan 14, 2020).
Original GitHub issue: https://github.com/hoppscotch/hoppscotch/issues/488

Originally assigned to: @alecananian on GitHub.

Describe the bug
I've found about 150+ unique hard-coded strings in the application code for titles, placeholders, toast messages, etc that are untranslatable because they're not set up to be compatible with nuxt-i18n.

To Reproduce
Steps to reproduce the behavior:

Select any language other than English
Observe untranslated strings even on the homepage ("search history", "History is empty", etc)

Expected behavior
All phrases are available for translation in the localized JSON files

OS: any
Browser: any
Version: any

Additional context
I can create a pull request fixing as many of these as I could find, it just touches a ton of files so I wanted to confirm it's desired first or if the maintainers have any further suggestions.

Originally created by @alecananian on GitHub (Jan 14, 2020). Original GitHub issue: https://github.com/hoppscotch/hoppscotch/issues/488 Originally assigned to: @alecananian on GitHub. **Describe the bug** I've found about 150+ unique hard-coded strings in the application code for titles, placeholders, toast messages, etc that are untranslatable because they're not set up to be compatible with `nuxt-i18n`. **To Reproduce** Steps to reproduce the behavior: 1. Select any language other than English 2. Observe untranslated strings even on the homepage ("search history", "History is empty", etc) **Expected behavior** All phrases are available for translation in the localized JSON files - OS: any - Browser: any - Version: any **Additional context** I can create a pull request fixing as many of these as I could find, it just touches a ton of files so I wanted to confirm it's desired first or if the maintainers have any further suggestions.

kerem

2026-03-16 13:58:10 +03:00

closed this issue
added the
help wanted

feature

wip
labels

kerem commented

2026-03-16 13:58:26 +03:00

Author

Owner

@liyasthomas commented on GitHub (Jan 14, 2020):

So sorry for this, i18n needs contributors such as you to make it complete. Core devs have been busy with other feature requests and bug fixes and have very little time to work on translations.

If you're willing to take this challenge, we're happy for that. Shall I assign this task to you?

@liyasthomas commented on GitHub (Jan 14, 2020): So sorry for this, `i18n` needs contributors such as you to make it complete. Core devs have been busy with other feature requests and bug fixes and have very little time to work on translations. If you're willing to take this challenge, we're happy for that. Shall I assign this task to you?

kerem commented

2026-03-16 13:58:31 +03:00

Author

Owner

@alecananian commented on GitHub (Jan 14, 2020):

Sure! Happy to do it. Does it make sense to do this as a branch off the current typescript branch since they both touch many files, or just off master?

@alecananian commented on GitHub (Jan 14, 2020): Sure! Happy to do it. Does it make sense to do this as a branch off the current `typescript` branch since they both touch many files, or just off `master`?

kerem commented

2026-03-16 13:58:36 +03:00

Author

Owner

@liyasthomas commented on GitHub (Jan 14, 2020):

Let me make master and i18n branch even and will let you know in 2 mins.

@liyasthomas commented on GitHub (Jan 14, 2020): Let me make `master` and `i18n` branch even and will let you know in 2 mins.

kerem commented

2026-03-16 13:58:41 +03:00

Author

Owner

@liyasthomas commented on GitHub (Jan 14, 2020):

Here you go: https://github.com/liyasthomas/postwoman/tree/i18n

i18n contributuion checklist:

Pull the latest changes from i18n branch
Find lang/<<your_file>>.js
Replace existing dummy translations with actual translated lacale (no need to update nuxt.config.js if language is already added once)
Save changes, Commit changes, Push to i18n branch only

Refer English translation file https://github.com/liyasthomas/postwoman/blob/i18n/lang/en-US.js (most prolly outdated!) for reference and stylings. Ping me for any doubts.

@liyasthomas commented on GitHub (Jan 14, 2020): Here you go: https://github.com/liyasthomas/postwoman/tree/i18n **`i18n` contributuion checklist:** - [ ] **Pull the latest changes from `i18n` branch** - [ ] Find `lang/<<your_file>>.js` - [ ] **Replace existing dummy translations** with actual translated lacale (no need to update `nuxt.config.js` if language is already added once) - [ ] Save changes, Commit changes, **Push to `i18n` branch only** Refer English translation file https://github.com/liyasthomas/postwoman/blob/i18n/lang/en-US.js (most prolly outdated!) for reference and stylings. Ping me for any doubts.

kerem commented

2026-03-16 13:58:46 +03:00

Author

Owner

@alecananian commented on GitHub (Jan 14, 2020):

Seems I couldn't commit directly to this repository, so I forked the i18n branch. Here are the changes: https://github.com/liyasthomas/postwoman/pull/489

@alecananian commented on GitHub (Jan 14, 2020): Seems I couldn't commit directly to this repository, so I forked the `i18n` branch. Here are the changes: https://github.com/liyasthomas/postwoman/pull/489

kerem commented

2026-03-16 13:58:51 +03:00

Author

Owner

@liyasthomas commented on GitHub (Jan 14, 2020):

Fixed in #490 #491

@liyasthomas commented on GitHub (Jan 14, 2020): Fixed in #490 #491

kerem referenced this issue

2026-03-17 00:10:29 +03:00

[PR #191] [MERGED] ⬆️ Bump yargs-parser from 14.0.0 to 15.0.0 #2471