mirror of
https://github.com/hoppscotch/hoppscotch.git
synced 2026-04-26 01:06:00 +03:00
[GH-ISSUE #394] Raw input disabled is not working properly #145
Labels
No labels
CodeDay
a11y
browser limited
bug
bug fix
cli
core
critical
design
desktop
discussion
docker
documentation
duplicate
enterprise
feature
feature
fosshack
future
good first issue
hacktoberfest
help wanted
i18n
invalid
major
minor
need information
need testing
not applicable to hoppscotch
not reproducible
pull-request
question
refactor
resolved
sandbox
self-host
spam
stale
testmu
wip
wont fix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/hoppscotch#145
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @elangosundar on GitHub (Dec 3, 2019).
Original GitHub issue: https://github.com/hoppscotch/hoppscotch/issues/394
Originally assigned to: @liyasthomas on GitHub.
Describe the bug
Raw input disabled is not working properly
To Reproduce
Steps to reproduce the behavior:
Please fix this issue.
Expected behavior
If RAW INPUTS is disabled, it should not pass in API request
Screenshots
If applicable, add screenshots to help explain your problem.
Desktop (please complete the following information):
@liyasthomas commented on GitHub (Dec 3, 2019):
I couldn't reproduce this issue. GET doesn't pass raw payload in request.
@elangosundar commented on GitHub (Dec 3, 2019):
@liyasthomas can you tried the above reproduce steps.
It is simple ,
you add some raw data in POST method and just on/off the raw input after that you will change method as GET method, now you will check above request parmas.
@liyasthomas commented on GitHub (Dec 4, 2019):
That's a feature. Actually when you disable the raw input or changed to any other
method, payload is stored to the app's state so it could be used next time.Think of this as: You send a POST request with some payload and have to check it's GET response. So you switched to GET and send another request. Now, if we clear the POST payload, you've to type in all payload again since it is not in app's memory anymore. This is why payload is preserved for using next time.
And don't worry, GET requests won't send payload. It's just for saving the state in your
localStorage.