mirror of
https://github.com/hoppscotch/hoppscotch.git
synced 2026-04-25 16:55:59 +03:00
[GH-ISSUE #390] Save to collections after deleting all the collections causes an error page #143
Labels
No labels
CodeDay
a11y
browser limited
bug
bug fix
cli
core
critical
design
desktop
discussion
docker
documentation
duplicate
enterprise
feature
feature
fosshack
future
good first issue
hacktoberfest
help wanted
i18n
invalid
major
minor
need information
need testing
not applicable to hoppscotch
not reproducible
pull-request
question
refactor
resolved
sandbox
self-host
spam
stale
testmu
wip
wont fix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/hoppscotch#143
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @aksappy on GitHub (Dec 2, 2019).
Original GitHub issue: https://github.com/hoppscotch/hoppscotch/issues/390
Originally assigned to: @liyasthomas on GitHub.
Describe the bug
When trying to save to collection, after deleting all the existing collection throws
To Reproduce
Steps to reproduce the behavior:
Expected behavior
Either say that there is no collection OR Save without a collection OR prompt for new collection
Screenshots
Desktop (please complete the following information):
@ialexreis commented on GitHub (Dec 8, 2019):
I'm checking out this bug, and I detected that some array validation was missing.
Maybe this should be fixed with the recreation of a default collection "My Collection", in background or with a modal showing on the page, with the collection creation form.
What do you guys think is the best solution?
@ialexreis commented on GitHub (Dec 8, 2019):
@liyasthomas Implemented this validation, to prevent this bug from happenning..
Launching PR.