starred/hoppscotch

Fork 0

mirror of https://github.com/hoppscotch/hoppscotch.git synced 2026-04-25 16:55:59 +03:00

[GH-ISSUE #3581] Team owner email address validation need improve #1228

New issue

Closed

opened 2026-03-16 19:24:30 +03:00 by kerem · 11 comments

kerem commented

2026-03-16 19:24:30 +03:00

Owner

Originally created by @WestFarmer on GitHub (Nov 22, 2023).
Original GitHub issue: https://github.com/hoppscotch/hoppscotch/issues/3581

Originally assigned to: @joeljstephen on GitHub.

Is there an existing issue for this?

I have searched the existing issues

Current behavior

for example :

fanguogang@itps.xxx.com

this is a valid email address, but when input it as owner email when creating team in admin dashboard.

client side validation shows 'please enter a valid owner email'

maybe this is caused by third level domain name in email address ?

this is blocking administrator to create team.

Steps to reproduce

go to admin dashboard
create a new team with owner email provided above.

Environment

Production

Version

Self-hosted

Originally created by @WestFarmer on GitHub (Nov 22, 2023). Original GitHub issue: https://github.com/hoppscotch/hoppscotch/issues/3581 Originally assigned to: @joeljstephen on GitHub. ### Is there an existing issue for this? - [X] I have searched the existing issues ### Current behavior for example : ``` fanguogang@itps.xxx.com ``` this is a valid email address, but when input it as owner email when creating team in admin dashboard. client side validation shows 'please enter a valid owner email' maybe this is caused by third level domain name in email address ? this is blocking administrator to create team. ### Steps to reproduce 1. go to admin dashboard 2. create a new team with owner email provided above. ### Environment Production ### Version Self-hosted

kerem

2026-03-16 19:24:30 +03:00

closed this issue
added the
bug

need testing

self-host
labels

kerem commented

2026-03-16 19:24:46 +03:00

Author

Owner

@liyasthomas commented on GitHub (Nov 22, 2023):

fanguogang@itps.xxx.com doesn't seem like an invalid email ID pattern.

@balub is this because the user email is not found in the users' table — can you check?

@liyasthomas commented on GitHub (Nov 22, 2023): `fanguogang@itps.xxx.com` doesn't seem like an invalid email ID pattern. @balub is this because the user email is not found in the users' table — can you check?

kerem commented

2026-03-16 19:24:51 +03:00

Author

Owner

@balub commented on GitHub (Nov 22, 2023):

There is a chance the regex we use may consider this as an invalid email. It's just a theory that we will test it out then we'll know for sure.

@balub commented on GitHub (Nov 22, 2023): There is a chance the regex we use may consider this as an invalid email. It's just a theory that we will test it out then we'll know for sure.

kerem commented

2026-03-16 19:24:56 +03:00

Author

Owner

@liyasthomas commented on GitHub (Nov 22, 2023):

If that's the case, if it's a front-end validation error, loop in @JoelJacobStephen to fix.

@liyasthomas commented on GitHub (Nov 22, 2023): If that's the case, if it's a front-end validation error, loop in @JoelJacobStephen to fix.

kerem commented

2026-03-16 19:25:01 +03:00

Author

Owner

@WestFarmer commented on GitHub (Nov 22, 2023):

If that's the case, if it's a front-end validation error, loop in @JoelJacobStephen to fix.

it's front-end, no request made to backends yet. @liyasthomas

@WestFarmer commented on GitHub (Nov 22, 2023): > If that's the case, if it's a front-end validation error, loop in @JoelJacobStephen to fix. it's front-end, no request made to backends yet. @liyasthomas

kerem commented

2026-03-16 19:25:06 +03:00

Author

Owner

@WestFarmer commented on GitHub (Nov 22, 2023):

from the source code.

only checking for non-empty value for owner email:

if (ownerEmail.value.trim() === '') {
    toast.error(`${t('teams.valid_owner_email')}`);
    return;
  }

When entering all the correct values at once, there is no problem. But there will be problems if the following scenario occurs:

input a valid email as owner email
input a invalid team name( eg: a name with length under 6)
submit, seeing error team name too short
input valid team name
submit again
seeing 'please enter valid owner email'

@liyasthomas

@WestFarmer commented on GitHub (Nov 22, 2023): from the [source code](https://github.com/hoppscotch/hoppscotch/blob/main/packages/hoppscotch-sh-admin/src/components/teams/Add.vue). only checking for non-empty value for owner email: ``` if (ownerEmail.value.trim() === '') { toast.error(`${t('teams.valid_owner_email')}`); return; } ``` When entering all the correct values at once, there is no problem. But there will be problems if the following scenario occurs: 1. input a valid email as owner email 2. input a invalid team name( eg: a name with length under 6) 3. submit, seeing error team name too short 4. input valid team name 5. submit again 6. seeing 'please enter valid owner email' @liyasthomas

kerem commented

2026-03-16 19:25:11 +03:00

Author

Owner

@liyasthomas commented on GitHub (Nov 22, 2023):

submit again

@WestFarmer when you submit again, is the email input field empty or not? Does it actually have a valid email ID at that time?

@liyasthomas commented on GitHub (Nov 22, 2023): > 5. submit again @WestFarmer when you submit again, is the email input field empty or not? Does it actually have a valid email ID at that time?

kerem commented

2026-03-16 19:25:16 +03:00

Author

Owner

@WestFarmer commented on GitHub (Nov 22, 2023):

submit again

@WestFarmer when you submit again, is the email input field empty or not? Does it actually have a valid email ID at that time?

of course, the email remains there.

@WestFarmer commented on GitHub (Nov 22, 2023): > > 5. submit again > > @WestFarmer when you submit again, is the email input field empty or not? Does it actually have a valid email ID at that time? of course, the email remains there.

kerem commented

2026-03-16 19:25:22 +03:00

Author

Owner

@joeljstephen commented on GitHub (Nov 23, 2023):

@WestFarmer I have raised a PR to fix the issue and have validated the fix from my end. Can you let me know if this PR properly fixes your issue?

@joeljstephen commented on GitHub (Nov 23, 2023): @WestFarmer I have raised a PR to fix the issue and have validated the fix from my end. Can you let me know if this PR properly fixes your issue?

kerem commented

2026-03-16 19:25:27 +03:00

Author

Owner

@WestFarmer commented on GitHub (Nov 24, 2023):

@WestFarmer I have raised a PR to fix the issue and have validated the fix from my end. Can you let me know if this PR properly fixes your issue?

How can I help to verify ? Do I need to checkout PR and build locally ?

@WestFarmer commented on GitHub (Nov 24, 2023): > @WestFarmer I have raised a PR to fix the issue and have validated the fix from my end. Can you let me know if this PR properly fixes your issue? How can I help to verify ? Do I need to checkout PR and build locally ?

kerem commented

2026-03-16 19:25:32 +03:00

Author

Owner

@balub commented on GitHub (Jan 11, 2024):

@WestFarmer Yes, you can checkout to the branch the PR is raised against build run it locally and try.

@balub commented on GitHub (Jan 11, 2024): @WestFarmer Yes, you can checkout to the branch the PR is raised against build run it locally and try.

kerem commented

2026-03-16 19:25:37 +03:00

Author

Owner

@joeljstephen commented on GitHub (Apr 10, 2024):

@WestFarmer I will be closing this issue in a few days as this has been fixed. Please let us know if you are still facing the same issue in the latest build.

@joeljstephen commented on GitHub (Apr 10, 2024): @WestFarmer I will be closing this issue in a few days as this has been fixed. Please let us know if you are still facing the same issue in the latest build.

kerem referenced this issue

2026-03-17 00:47:38 +03:00

[PR #1228] [CLOSED] WIP Feat/websockets headers #3153