mirror of
https://github.com/hoppscotch/hoppscotch.git
synced 2026-04-25 16:55:59 +03:00
[GH-ISSUE #3572] [bug]: Allow Client Secret for OAuth2 Authentication #1225
Labels
No labels
CodeDay
a11y
browser limited
bug
bug fix
cli
core
critical
design
desktop
discussion
docker
documentation
duplicate
enterprise
feature
feature
fosshack
future
good first issue
hacktoberfest
help wanted
i18n
invalid
major
minor
need information
need testing
not applicable to hoppscotch
not reproducible
pull-request
question
refactor
resolved
sandbox
self-host
spam
stale
testmu
wip
wont fix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/hoppscotch#1225
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @Dan6erbond on GitHub (Nov 21, 2023).
Original GitHub issue: https://github.com/hoppscotch/hoppscotch/issues/3572
Is there an existing issue for this?
Current behavior
Previously Hoppscotch would allow setting no client secret for OAuth2 authentication, which would then trigger the client credentials flow for providers such as Azure AD.
The recent 2023.8.4 release adds validation for the
clientSecretthat forces users to set it, which will trigger the authorization code flow.However, authorization code cannot be used, because Hoppscotch's final token exchange happens on the client, where Azure AD has CORS headers that block the request as well as a check on the
Originheader, throwing the following error with a 400 Bad Request:Steps to reproduce
Environment
Production
Version
Cloud
@liyasthomas commented on GitHub (Nov 21, 2023):
@amk-dev can you look into this?