mirror of
https://github.com/hoppscotch/hoppscotch.git
synced 2026-04-26 01:06:00 +03:00
[GH-ISSUE #3381] [bug]: Workspaces/Team Environments get's deleted by changing Team #1129
Labels
No labels
CodeDay
a11y
browser limited
bug
bug fix
cli
core
critical
design
desktop
discussion
docker
documentation
duplicate
enterprise
feature
feature
fosshack
future
good first issue
hacktoberfest
help wanted
i18n
invalid
major
minor
need information
need testing
not applicable to hoppscotch
not reproducible
pull-request
question
refactor
resolved
sandbox
self-host
spam
stale
testmu
wip
wont fix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/hoppscotch#1129
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @RaHehl on GitHub (Sep 21, 2023).
Original GitHub issue: https://github.com/hoppscotch/hoppscotch/issues/3381
Is there an existing issue for this?
Current behavior
Team environment get's deleted if u switch the team
Steps to reproduce
Environment
Production
Version
Self-hosted
@RaHehl commented on GitHub (Sep 21, 2023):
it's a little strange. I created the bug based on repeated feedback from multiple internal users. After I was able to reproduce the behavior even in incognito mode. env created team changed, everything empty. Now suddenly all the previously disappeared env are back and I can no longer reproduce it.
@balub commented on GitHub (Sep 25, 2023):
Hey, @RaHehl I want to confirm the issue so we can narrow down and find the problem.
Is this is issue or am I missing anything?
@RaHehl commented on GitHub (Sep 27, 2023):
@balub Right, that was the behavior I had, but now I can't reproduce it.
But I just noticed something: maybe it has something to do with bug #3393. I originally attached a screenshot of the request here, but when I saw that a CreateUserEnvironment was visible in the image instead of a CreateTeamEnvironment, I took the screenshot out again because I thought I had included it incorrectly.
In addition, I just had the behavior that I was logged in from yesterday (via MS), but I couldn't see my teams until I logged out and logged in again. Other users have sporadically reported the same behavior to me in our instance.
@RaHehl commented on GitHub (Nov 1, 2023):
A user saw something like this in the dev tools when it occurred:
operationName: GetTeamEnvironments
Throttling 419
Is it Possible this "throttler-behind-proxy" https://github.com/hoppscotch/hoppscotch/blob/main/packages/hoppscotch-backend/src/guards/throttler-behind-proxy.guard.ts
Is not configured for the "team-environments.resolver"
https://github.com/hoppscotch/hoppscotch/blob/main/packages/hoppscotch-backend/src/team-environments/team-environments.resolver.ts
With the result: The requests of all users via the Kubernetes Ingress Proxy are counted as coming from one IP, the IP of the Ingress Proxy?
@balub commented on GitHub (Jan 11, 2024):
@RaHehl I apologise for the time it took to get to this issue, but after looking into this it seems certain field-resolvers for certain modules do not have any rate-limiting on them. In addition to that maybe the lack of extracting the source IP of the requests in the
GqlThrottlerGuardcould cause issues when working with proxies. Will run some tests to confirm the same.@balub commented on GitHub (Jul 17, 2024):
@RaHehl are you still encountering this issue, if not I believe its safe to close this issue ?
@RaHehl commented on GitHub (Jul 17, 2024):
@balub At least I haven't had any reports from users about this for a while, so I agree with you closing this