mirror of
https://github.com/hoppscotch/hoppscotch.git
synced 2026-04-25 16:55:59 +03:00
[GH-ISSUE #3078] [bug]: Incorrect invite link #1008
Labels
No labels
CodeDay
a11y
browser limited
bug
bug fix
cli
core
critical
design
desktop
discussion
docker
documentation
duplicate
enterprise
feature
feature
fosshack
future
good first issue
hacktoberfest
help wanted
i18n
invalid
major
minor
need information
need testing
not applicable to hoppscotch
not reproducible
pull-request
question
refactor
resolved
sandbox
self-host
spam
stale
testmu
wip
wont fix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/hoppscotch#1008
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @eljump on GitHub (May 24, 2023).
Original GitHub issue: https://github.com/hoppscotch/hoppscotch/issues/3078
Originally assigned to: @ankitsridhar16 on GitHub.
Is there an existing issue for this?
Current behavior
Hi all, i find one more bug.
When we send the invite link (from) admin to email, people get link on our main domain, but not invite link, only domain. There is no any query-params in link.
Now i use branch release/2023.4.2 (there was fixed auth bug).
Also, if we send invite from main screen (not admin), we have a problem, that in link placed domain hoppscotch.io, but i think there should be our domain (hoppscotch-webest.ru)
Steps to reproduce
Use release/2023.4.2 branch. All other steps from documentation.
Environment
Release
Version
Self-hosted
@ankitsridhar16 commented on GitHub (May 26, 2023):
Hello @eljump
If I understand correctly when you were inviting a user by email you were inviting them to join/sign-in to your infra? If this is the case then the email sent contains link where you main frontend app is running.
For the second issue were you inviting members to join a team from the main screen ?
@eljump commented on GitHub (May 29, 2023):
Hello, @ankitsridhar16
yes, you're right
if i invite from here
I got
without any params, as i can see
If I invite from here
I got link with hoppscotch.io domain
@ankitsridhar16 commented on GitHub (May 29, 2023):
@eljump so the expected behaviour should have been when inviting from teams in the main screen you should have received an email invitation in the following format -
https://your-domain/join-team?id=##am I correct ?You don't have an issue getting the first invitation when inviting a user through admin UI as -
https://your-domain?@eljump commented on GitHub (May 29, 2023):
@ankitsridhar16
Why you ask the same questions?
I signed all screenshots,
if i send invite from admin panel, the people got link with my domain, but it is no auth,
so on click they can go to my hoppscotch domain, link look like:
https://your-domain
You can see this on 1 and 2 screenshots.
If i send invite, like on 3 screenshot (from main screen),
people got link with not my domain, but with domain, hoppscotch.io, it is on 4 screenshot.
I think, that there should be my domain, because i invite people to my team.
@ankitsridhar16 commented on GitHub (May 29, 2023):
Thanks wanted to clarify @eljump
The first behaviour is expected. When you invite a user we currently send an email with your domain (without any parameters) so that they can select the type of Auth they want to use for sign in.
The team invitation behaviour where you should get your domain in the email is a bug and we will have a fix for that.
@eljump commented on GitHub (May 29, 2023):
@ankitsridhar16 Okey, i understand you, thanks for answers
@liyasthomas commented on GitHub (Jun 4, 2023):
This has been resolved in #3096.