mirror of
https://github.com/hickory-dns/hickory-dns.git
synced 2026-04-25 03:05:51 +03:00
[GH-ISSUE #2404] Unexpected ANSWER and RCODE for non-existent SOA query #980
Labels
No labels
blocked
breaking-change
bug
bug:critical
bug:tests
cleanup
compliance
compliance
compliance
crate:all
crate:client
crate:native-tls
crate:proto
crate:recursor
crate:resolver
crate:resolver
crate:rustls
crate:server
crate:util
dependencies
docs
duplicate
easy
easy
enhance
enhance
enhance
feature:dns-over-https
feature:dns-over-quic
feature:dns-over-tls
feature:dnsssec
feature:global_lb
feature:mdns
feature:tsig
features:edns
has workaround
ops
perf
platform:WASM
platform:android
platform:fuchsia
platform:linux
platform:macos
platform:windows
pull-request
question
test
tools
tools
trust
unclear
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/hickory-dns#980
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @PRRIN on GitHub (Sep 2, 2024).
Original GitHub issue: https://github.com/hickory-dns/hickory-dns/issues/2404
What happened:
When querying for a non-existent SOA record, the ANSWER section should be empty. However, the SOA record is incorrectly returned in ANSWER section, and the RCODE incorrectly returns
NOERRORinstead ofNXDOMAIN.How to reproduce it (as minimally and precisely as possible):
Using the following zone file (
a.zone):and this zone config (
zone.toml):Response for querying
<b.a., SOA>:What you expected to happen:
The RCODE should not be
NOERROR, and the ANSWER section should not include thea. SOArecord.It's caused by the last
matchexpression inInMemoryAuthority::search:The lookup for the
SOAbranch should use the same parameters as the standard lookup path.Environment:
v0.24.1, 6334a01Bind9 behavior under the same setup: the RCODE is
NXDOMAIN, and the AUTHORITY section isa. SOA.@djc commented on GitHub (Sep 2, 2024):
Thanks for the report! Would you be able to submit a PR to fix this?
@PRRIN commented on GitHub (Sep 3, 2024):
Thanks for your recognition! I think it would be better to have a more thorough testing process before making this change. However, I am currently tied up with other tasks and unable to fix this bug at this time.