mirror of
https://github.com/hickory-dns/hickory-dns.git
synced 2026-04-25 19:25:56 +03:00
[GH-ISSUE #2320] Latest release of tokio dependency fails past-future (1.67.0) CI job #967
Labels
No labels
blocked
breaking-change
bug
bug:critical
bug:tests
cleanup
compliance
compliance
compliance
crate:all
crate:client
crate:native-tls
crate:proto
crate:recursor
crate:resolver
crate:resolver
crate:rustls
crate:server
crate:util
dependencies
docs
duplicate
easy
easy
enhance
enhance
enhance
feature:dns-over-https
feature:dns-over-quic
feature:dns-over-tls
feature:dnsssec
feature:global_lb
feature:mdns
feature:tsig
features:edns
has workaround
ops
perf
platform:WASM
platform:android
platform:fuchsia
platform:linux
platform:macos
platform:windows
pull-request
question
test
tools
tools
trust
unclear
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/hickory-dns#967
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @justahero on GitHub (Jul 24, 2024).
Original GitHub issue: https://github.com/hickory-dns/hickory-dns/issues/2320
Describe the bug
Recent CI builds fail the past-future (1.67.0) job with the following error message:
The
tokiodependency resolves to version1.39.1which has been released on 23rd of July, 2024 (yesterday). Themiodependency now resolves to version1.0.1.tokio's MSRV has been updated to1.70.0(from1.63.0).To Reproduce
Open a PR to run the CI workflow, see failing CI job for #2318 for example.
Expected behavior
It's expected that the CI workflow passes successfully.
System:
1.67.0Version:
Crate: hickory-proto
Version:
mainAdditional context
There are two options, either
tokiois fixed to a previous working version in theCargo.toml(it's currently set to1.21) or the CI job needs to be updated. Version1.37.0has been working fine on my machine so far.@djc commented on GitHub (Jul 24, 2024):
I'm actually confused why this is failing. We have a
Cargo.lockfile committed which should make sure that CI uses the same versions of dependencies on every run until we update the lockfile again. So I wonder why that isn't happening here?@justahero commented on GitHub (Jul 24, 2024):
The Cargo.toml states
the failing command in
just no-default-featuresisso it may bypass the one in
Cargo.lockafter a freshcargo build.