starred/hickory-dns

mirror of https://github.com/hickory-dns/hickory-dns.git synced 2026-04-25 11:15:54 +03:00

[GH-ISSUE #207] Change signature fo insert_trust_anchor to take PublicKey #94

New issue

Closed

opened 2026-03-07 22:18:47 +03:00 by kerem · 0 comments

kerem commented

2026-03-07 22:18:47 +03:00

Owner

Originally created by @bluejekyll on GitHub (Sep 24, 2017).
Original GitHub issue: https://github.com/hickory-dns/hickory-dns/issues/207

Originally assigned to: @bluejekyll on GitHub.

This should lower the potential for mistakenly associating the wrong data:

pub fn insert_trust_anchor(&mut self, public_key: Vec<u8>) -> TrustAnchor {...}

should become

pub fn insert_trust_anchor(&mut self, public_key: PublicKey) -> TrustAnchor {...}

Originally created by @bluejekyll on GitHub (Sep 24, 2017). Original GitHub issue: https://github.com/hickory-dns/hickory-dns/issues/207 Originally assigned to: @bluejekyll on GitHub. This should lower the potential for mistakenly associating the wrong data: ```rust pub fn insert_trust_anchor(&mut self, public_key: Vec<u8>) -> TrustAnchor {...} ``` should become ```rust pub fn insert_trust_anchor(&mut self, public_key: PublicKey) -> TrustAnchor {...} ```

kerem

2026-03-07 22:18:47 +03:00

closed this issue
added the
trust

crate:client
labels

kerem referenced this issue

2026-03-16 01:55:38 +03:00

[PR #94] [MERGED] Rustfmt #1240

Sign in to join this conversation.

No labels

breaking-change

crate:native-tls

feature:dns-over-https

feature:dns-over-quic

feature:dns-over-tls

feature:dnsssec

feature:global_lb

platform:android

platform:fuchsia

platform:windows

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/hickory-dns#94

No description provided.