[GH-ISSUE #2115] build/test compilation error in client when only enabling feature dns-over-https #891

Open
opened 2026-03-16 00:45:54 +03:00 by kerem · 2 comments
Owner

Originally created by @alexanderkjall on GitHub (Dec 24, 2023).
Original GitHub issue: https://github.com/hickory-dns/hickory-dns/issues/2115

Describe the bug

The dns-over-https feature relies on rustls.

To Reproduce
Steps to reproduce the behavior:

In the crates/client/ directory:

$ cargo build --no-default-features --features dns-over-https
   Compiling hickory-client v0.24.0 (/home/capitol/project/hickory-dns/crates/client)
error[E0432]: unresolved import `rustls`
  --> crates/client/src/h2_client_connection.rs:16:5
   |
16 | use rustls::ClientConfig;
   |     ^^^^^^ help: a similar path exists: `hickory_proto::rustls`

For more information about this error, try `rustc --explain E0432`.
error: could not compile `hickory-client` (lib) due to previous error

Expected behavior

that cargo build / cargo test works

System:

  • OS: Arch
  • Architecture: x86_64
  • Version n/a
  • rustc version: 1.74.1

Version:
Crate: client
Version: git

Additional context
n/a

Originally created by @alexanderkjall on GitHub (Dec 24, 2023). Original GitHub issue: https://github.com/hickory-dns/hickory-dns/issues/2115 **Describe the bug** The `dns-over-https` feature relies on rustls. **To Reproduce** Steps to reproduce the behavior: In the `crates/client/` directory: ``` $ cargo build --no-default-features --features dns-over-https Compiling hickory-client v0.24.0 (/home/capitol/project/hickory-dns/crates/client) error[E0432]: unresolved import `rustls` --> crates/client/src/h2_client_connection.rs:16:5 | 16 | use rustls::ClientConfig; | ^^^^^^ help: a similar path exists: `hickory_proto::rustls` For more information about this error, try `rustc --explain E0432`. error: could not compile `hickory-client` (lib) due to previous error ``` **Expected behavior** that `cargo build` / `cargo test` works **System:** - OS: Arch - Architecture: x86_64 - Version n/a - rustc version: 1.74.1 **Version:** Crate: client Version: git **Additional context** n/a
Author
Owner

@djc commented on GitHub (Jan 9, 2024):

I think this might be similar to #2066, #2067, #2090?

<!-- gh-comment-id:1882828441 --> @djc commented on GitHub (Jan 9, 2024): I think this might be similar to #2066, #2067, #2090?
Author
Owner

@alexanderkjall commented on GitHub (Jan 13, 2024):

Yes, these things might have the same underlying cause. I'm not really familiar enough with the codebase to have an opinion on that.

Feel free to close this if you feel that it's a duplicate :)

<!-- gh-comment-id:1890751389 --> @alexanderkjall commented on GitHub (Jan 13, 2024): Yes, these things might have the same underlying cause. I'm not really familiar enough with the codebase to have an opinion on that. Feel free to close this if you feel that it's a duplicate :)
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/hickory-dns#891
No description provided.