[GH-ISSUE #190] resolver lookup_ip should checkout /etc/hosts/ before dns requests? #89

Closed
opened 2026-03-07 22:18:43 +03:00 by kerem · 5 comments
Owner

Originally created by @cssivision on GitHub (Sep 18, 2017).
Original GitHub issue: https://github.com/hickory-dns/hickory-dns/issues/190

Originally created by @cssivision on GitHub (Sep 18, 2017). Original GitHub issue: https://github.com/hickory-dns/hickory-dns/issues/190
kerem 2026-03-07 22:18:43 +03:00
Author
Owner

@bluejekyll commented on GitHub (Sep 18, 2017):

Yeah, hm. The library currently doesn't have any support for /etc/hosts. I can see how this would be a valuable request though.

<!-- gh-comment-id:330126526 --> @bluejekyll commented on GitHub (Sep 18, 2017): Yeah, hm. The library currently doesn't have any support for `/etc/hosts`. I can see how this would be a valuable request though.
Author
Owner

@cssivision commented on GitHub (Sep 18, 2017):

I think this is a most common feature.

<!-- gh-comment-id:330127806 --> @cssivision commented on GitHub (Sep 18, 2017): I think this is a most common feature.
Author
Owner

@cssivision commented on GitHub (Sep 18, 2017):

i think i can spend some time on this feature.

<!-- gh-comment-id:330128292 --> @cssivision commented on GitHub (Sep 18, 2017): i think i can spend some time on this feature.
Author
Owner

@bluejekyll commented on GitHub (Sep 18, 2017):

That would be cool! I can help see where is best to put it...

Off the top of my head, I think there should be a new config param, probably a map of all the Names->IPs: https://github.com/bluejekyll/trust-dns/blob/master/resolver/src/lookup_ip.rs#L156

and then possibly introduce a function or logic here, to lookup from that map: https://github.com/bluejekyll/trust-dns/blob/master/resolver/src/lookup_ip.rs#L156

It will be interesting to see how to thread that through...

<!-- gh-comment-id:330128743 --> @bluejekyll commented on GitHub (Sep 18, 2017): That would be cool! I can help see where is best to put it... Off the top of my head, I think there should be a new config param, probably a map of all the Names->IPs: https://github.com/bluejekyll/trust-dns/blob/master/resolver/src/lookup_ip.rs#L156 and then possibly introduce a function or logic here, to lookup from that map: https://github.com/bluejekyll/trust-dns/blob/master/resolver/src/lookup_ip.rs#L156 It will be interesting to see how to thread that through...
Author
Owner

@briansmith commented on GitHub (Oct 24, 2017):

This was fixed by #191 and should be closed, AFAICT. I filed follow-ups #251 and #252.

<!-- gh-comment-id:338872581 --> @briansmith commented on GitHub (Oct 24, 2017): This was fixed by #191 and should be closed, AFAICT. I filed follow-ups #251 and #252.
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/hickory-dns#89
No description provided.