mirror of
https://github.com/hickory-dns/hickory-dns.git
synced 2026-04-25 03:05:51 +03:00
[GH-ISSUE #2098] Incorrect interaction between Config.toml and SOA record #886
Labels
No labels
blocked
breaking-change
bug
bug:critical
bug:tests
cleanup
compliance
compliance
compliance
crate:all
crate:client
crate:native-tls
crate:proto
crate:recursor
crate:resolver
crate:resolver
crate:rustls
crate:server
crate:util
dependencies
docs
duplicate
easy
easy
enhance
enhance
enhance
feature:dns-over-https
feature:dns-over-quic
feature:dns-over-tls
feature:dnsssec
feature:global_lb
feature:mdns
feature:tsig
features:edns
has workaround
ops
perf
platform:WASM
platform:android
platform:fuchsia
platform:linux
platform:macos
platform:windows
pull-request
question
test
tools
tools
trust
unclear
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/hickory-dns#886
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @SivaKesava1 on GitHub (Nov 30, 2023).
Original GitHub issue: https://github.com/hickory-dns/hickory-dns/issues/2098
Describe the bug
If a user, by mistake, uploads a zone file which has no FQDN, then there is some strange interaction between the Config.toml file and the SOA record. This may not be very realistic but recording the behavior of TrustDNS.
To Reproduce
Consider the following simple zone file:
with config.toml as:
Please note that there are no
.in the zone file or in the Config file.TrustDNS considers the zone as that of
testfrom the Config and all the records names are relative names.Expected behavior
If you query for the
SOArecord either usingtest.test.ortest.then we do not get theSOArecord, but the RCODE isNOERROR. However, if I query<test.test., NS>, I get theNSrecord and similarly the IP record with<foo.test.>. I have tried to obtain the SOA record, but I could not find. This is strange because there is a zone calledtest.that should have the SOA record. A possible solution is to raise an error and not load the zone file when the zone file is like this.System:
OS: Ubuntu
Architecture: x86_64
Version: 18
rustc version: cargo 1.47.0
Version:
Crate: server
Version: :Trust-DNS 0.23.1
@djc commented on GitHub (Dec 1, 2023):
Have you tried the hickory-dns 0.24 release? IIRC it has some changes to zone file parsing that might affect stuff like this.