mirror of
https://github.com/hickory-dns/hickory-dns.git
synced 2026-04-25 11:15:54 +03:00
[GH-ISSUE #2044] read_system_conf returns different Error types on unix vs windows #859
Labels
No labels
blocked
breaking-change
bug
bug:critical
bug:tests
cleanup
compliance
compliance
compliance
crate:all
crate:client
crate:native-tls
crate:proto
crate:recursor
crate:resolver
crate:resolver
crate:rustls
crate:server
crate:util
dependencies
docs
duplicate
easy
easy
enhance
enhance
enhance
feature:dns-over-https
feature:dns-over-quic
feature:dns-over-tls
feature:dnsssec
feature:global_lb
feature:mdns
feature:tsig
features:edns
has workaround
ops
perf
platform:WASM
platform:android
platform:fuchsia
platform:linux
platform:macos
platform:windows
pull-request
question
test
tools
tools
trust
unclear
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/hickory-dns#859
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @seanmonstar on GitHub (Oct 3, 2023).
Original GitHub issue: https://github.com/hickory-dns/hickory-dns/issues/2044
Describe the bug
On Windows,
read_system_conf()has the return typeResolveResult<(ResolverConfig, ResolverOpts)>, whereas on Unix, it has the return type ofio::Result<(ResolverConfig, ResolverOpts)>.Is this intentional? If so, should users expect to use
#[cfg]to handle the difference in types?Version:
Crate: resolver
Version: 0.23.0
Additional context
Noticed here: https://github.com/seanmonstar/reqwest/issues/1991
@djc commented on GitHub (Oct 4, 2023):
Probably more like an oversight. Proposed fix in #2047.