mirror of
https://github.com/hickory-dns/hickory-dns.git
synced 2026-04-25 19:25:56 +03:00
[GH-ISSUE #2017] RecordType does not implement Deserialize... but it does? #851
Labels
No labels
blocked
breaking-change
bug
bug:critical
bug:tests
cleanup
compliance
compliance
compliance
crate:all
crate:client
crate:native-tls
crate:proto
crate:recursor
crate:resolver
crate:resolver
crate:rustls
crate:server
crate:util
dependencies
docs
duplicate
easy
easy
enhance
enhance
enhance
feature:dns-over-https
feature:dns-over-quic
feature:dns-over-tls
feature:dnsssec
feature:global_lb
feature:mdns
feature:tsig
features:edns
has workaround
ops
perf
platform:WASM
platform:android
platform:fuchsia
platform:linux
platform:macos
platform:windows
pull-request
question
test
tools
tools
trust
unclear
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/hickory-dns#851
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @cetanu on GitHub (Sep 4, 2023).
Original GitHub issue: https://github.com/hickory-dns/hickory-dns/issues/2017
Describe the bug
Trying to just include the
RecordTypein a struct which derivesDeserializeand it's not workingTo Reproduce
code:
Expected behavior
RecordTypeis compiled withDeserializedue to theserde-configfeature being usedActual behavior
System:
Version:
Crate: trusty-dns-client
Version: 0.23
@djc commented on GitHub (Sep 4, 2023):
It looks like there's a bug in that the trust-dns-client isn't forwarding the
serde-configflag to its dependency on trust-dns-proto, which is whereRecordTypeactually lives. Can you send a PR?@cetanu commented on GitHub (Sep 5, 2023):
TIL how to forward features onto other crates, I think the linked PR is the fix?
I'm not sure how to add tests for this (or if they are wanted)
@djc commented on GitHub (Sep 6, 2023):
I don't think we need tests for this.