mirror of
https://github.com/hickory-dns/hickory-dns.git
synced 2026-04-25 11:15:54 +03:00
[GH-ISSUE #1926] Try next DNS server when the first one doesn’t have the requested type #820
Labels
No labels
blocked
breaking-change
bug
bug:critical
bug:tests
cleanup
compliance
compliance
compliance
crate:all
crate:client
crate:native-tls
crate:proto
crate:recursor
crate:resolver
crate:resolver
crate:rustls
crate:server
crate:util
dependencies
docs
duplicate
easy
easy
enhance
enhance
enhance
feature:dns-over-https
feature:dns-over-quic
feature:dns-over-tls
feature:dnsssec
feature:global_lb
feature:mdns
feature:tsig
features:edns
has workaround
ops
perf
platform:WASM
platform:android
platform:fuchsia
platform:linux
platform:macos
platform:windows
pull-request
question
test
tools
tools
trust
unclear
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/hickory-dns#820
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @GoldsteinE on GitHub (May 5, 2023).
Original GitHub issue: https://github.com/hickory-dns/hickory-dns/issues/1926
Is your feature request related to a problem? Please describe.
Sometimes the first DNS server returns a truncated response, that contains some records (e.g. CNAME record), but not the requested records (e.g. A record for this CNAME). Currently trust-dns-resolver returns an error for this case without trying the next server.
Describe the solution you'd like
When the first DNS server tried returns a (truncated?) response that doesn’t contain the requested record, try the next one.
Describe alternatives you've considered
If
.lookup()returned the server that was used to get these results on error, user could possibly just retry the request themselves.Of course, this feature could be configurable, with something like
Also trust-dns could retry the request over TCP in this case. I’d think that
try_tcp_on_errorwould do it, but apparently it doesn’t.@djc commented on GitHub (May 18, 2023):
Maybe that's a bug? You didn't provide many details about the specific error you're getting.
@bluejekyll commented on GitHub (Jun 20, 2023):
There's also the
trust_nx_responsessetting, it defaults to false, though it might only apply to NX_DOMAIN, and not to empty record_sets when the name exists but a particular type does not. I can't remember the implementation details off the top of my head and would need to look at the implementation to see.@GoldsteinE commented on GitHub (Jun 23, 2023):
I’m getting a “response truncated” error, but it’s hard to reproduce, because it only happens sometimes, with some hosts and specific DNS servers. I’ll write details if I’m able to create an example that reproduces at least somewhat reliably.