starred/hickory-dns

Fork 0

mirror of https://github.com/hickory-dns/hickory-dns.git synced 2026-04-25 03:05:51 +03:00

[GH-ISSUE #1866] Iterator size hints #797

New issue

Open

opened 2026-03-16 00:17:13 +03:00 by kerem · 6 comments

kerem commented

2026-03-16 00:17:13 +03:00

Owner

Originally created by @mattfbacon on GitHub (Dec 22, 2022).
Original GitHub issue: https://github.com/hickory-dns/hickory-dns/issues/1866

This crate includes some iterators. It would be nice if those iterators had proper size hints.

Originally created by @mattfbacon on GitHub (Dec 22, 2022). Original GitHub issue: https://github.com/hickory-dns/hickory-dns/issues/1866 This crate includes some iterators. It would be nice if those iterators had proper size hints.

kerem added the

perf

label

2026-03-16 00:17:13 +03:00

kerem commented

2026-03-16 00:17:24 +03:00

Author

Owner

@djc commented on GitHub (Dec 22, 2022):

Pull requests welcome!

@djc commented on GitHub (Dec 22, 2022): Pull requests welcome!

kerem commented

2026-03-16 00:17:29 +03:00

Author

Owner

@mattfbacon commented on GitHub (Dec 30, 2022):

OK, I will look into it

@mattfbacon commented on GitHub (Dec 30, 2022): OK, I will look into it

kerem commented

2026-03-16 00:17:34 +03:00

Author

Owner

@mattfbacon commented on GitHub (Dec 30, 2022):

I'm looking at the RrsigsByAlgorithms iterator implementation, specifically this part:

github.com/bluejekyll/trust-dns@249fb26608/crates/proto/src/rr/rr_set.rs (L560-L576)

What is this meant to do? As far as I can tell it will yield one item at most.

@mattfbacon commented on GitHub (Dec 30, 2022): I'm looking at the RrsigsByAlgorithms iterator implementation, specifically this part: https://github.com/bluejekyll/trust-dns/blob/249fb266089b6205e461dfff05d7fc40e92d22bb/crates/proto/src/rr/rr_set.rs#L560-L576 What is this meant to do? As far as I can tell it will yield one item at most.

kerem commented

2026-03-16 00:17:39 +03:00

Author

Owner

@bluejekyll commented on GitHub (Dec 31, 2022):

This creates an iterator limiting the RRSIG responses to hash algorithms the client understands and then reduces that to the strongest algorithm understood. That only happens if the client sends supported algorithms, otherwise it sends them all.

@bluejekyll commented on GitHub (Dec 31, 2022): This creates an iterator limiting the RRSIG responses to hash algorithms the client understands and then reduces that to the strongest algorithm understood. That only happens if the client sends supported algorithms, otherwise it sends them all.

kerem commented

2026-03-16 00:17:44 +03:00

Author

Owner

@mattfbacon commented on GitHub (Dec 31, 2022):

Ok so it will just yield 0 or 1 items in that case

@mattfbacon commented on GitHub (Dec 31, 2022): Ok so it will just yield 0 or 1 items in that case

kerem commented

2026-03-16 00:17:49 +03:00

Author

Owner

@bluejekyll commented on GitHub (Dec 31, 2022):

Well, 0, 1 or the number of RRSIGs by Algorithms (up to something like 4 or 5).

@bluejekyll commented on GitHub (Dec 31, 2022): Well, 0, 1 or the number of RRSIGs by Algorithms (up to something like 4 or 5).

kerem referenced this issue

2026-03-16 02:20:18 +03:00

[PR #797] [MERGED] add discord #1691