[GH-ISSUE #1824] proto::rr::domain::Label implements trait Borrow but does not fulfil requirements #783

New issue

Open

opened 2026-03-16 00:13:55 +03:00 by kerem · 2 comments

kerem commented

2026-03-16 00:13:55 +03:00

Owner

Originally created by @kaimaera on GitHub (Nov 5, 2022).
Original GitHub issue: https://github.com/hickory-dns/hickory-dns/issues/1824

github.com/bluejekyll/trust-dns@f7128a1a58/crates/proto/src/rr/domain/label.rs (L221-L225)

From Borrow:

In particular Eq, Ord and Hash must be equivalent for borrowed and owned values: x.borrow() == y.borrow() should give the same result as x == y.

However, Label implements Ord using an ASCII case insensitive comparison. cmp(x, b) != cmp(x.borrow(), y.borrow()). Same for PartialEq.

Originally created by @kaimaera on GitHub (Nov 5, 2022). Original GitHub issue: https://github.com/hickory-dns/hickory-dns/issues/1824 https://github.com/bluejekyll/trust-dns/blob/f7128a1a582af3e7ea2c5dbac28363afe2757bc9/crates/proto/src/rr/domain/label.rs#L221-L225 From [Borrow](https://doc.rust-lang.org/std/borrow/trait.Borrow.html): > In particular Eq, Ord and Hash must be equivalent for borrowed and owned values: x.borrow() == y.borrow() should give the same result as x == y. However, Label implements Ord using an ASCII case insensitive comparison. cmp(x, b) != cmp(x.borrow(), y.borrow()). Same for PartialEq.

kerem commented

2026-03-16 00:14:01 +03:00

Author

Owner

@djc commented on GitHub (Nov 7, 2022):

Nice catch! Do you want to propose a fix, ideally as a PR?

@djc commented on GitHub (Nov 7, 2022): Nice catch! Do you want to propose a fix, ideally as a PR?

kerem commented

2026-03-16 00:14:06 +03:00

Author

Owner

@kaimaera commented on GitHub (Nov 7, 2022):