[GH-ISSUE #1809] Memory leak in inner_join / JoinSet #776

Closed
opened 2026-03-16 00:12:27 +03:00 by kerem · 2 comments
Owner

Originally created by @gopa-eg on GitHub (Oct 26, 2022).
Original GitHub issue: https://github.com/hickory-dns/hickory-dns/issues/1809

https://github.com/bluejekyll/trust-dns/blob/main/crates/server/src/server/server_future.rs#L95

join_next() is never called on inner_join - hence the inner_join will keep growing per dns-request

Originally created by @gopa-eg on GitHub (Oct 26, 2022). Original GitHub issue: https://github.com/hickory-dns/hickory-dns/issues/1809 https://github.com/bluejekyll/trust-dns/blob/main/crates/server/src/server/server_future.rs#L95 join_next() is never called on inner_join - hence the inner_join will keep growing per dns-request
kerem closed this issue 2026-03-16 00:12:32 +03:00
Author
Owner

@bluejekyll commented on GitHub (Oct 27, 2022):

@jeff-hiner any chance you could look at this? I think it’s related to some of your changes. Could you verify if it’s an issue?

<!-- gh-comment-id:1293723037 --> @bluejekyll commented on GitHub (Oct 27, 2022): @jeff-hiner any chance you could look at this? I think it’s related to some of your changes. Could you verify if it’s an issue?
Author
Owner

@jeff-hiner commented on GitHub (Oct 31, 2022):

Yeah we need to eventually clean these up. I'd normally suggest doing a lazy try_join_next right after that spawn, but that doesn't exist. Maybe a now_or_never wrapper around join_next, in a loop?

<!-- gh-comment-id:1297252025 --> @jeff-hiner commented on GitHub (Oct 31, 2022): Yeah we need to eventually clean these up. I'd normally suggest doing a lazy `try_join_next` right after that spawn, but that doesn't exist. Maybe a `now_or_never` wrapper around `join_next`, in a loop?
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/hickory-dns#776
No description provided.