mirror of
https://github.com/hickory-dns/hickory-dns.git
synced 2026-04-25 19:25:56 +03:00
[GH-ISSUE #1809] Memory leak in inner_join / JoinSet #776
Labels
No labels
blocked
breaking-change
bug
bug:critical
bug:tests
cleanup
compliance
compliance
compliance
crate:all
crate:client
crate:native-tls
crate:proto
crate:recursor
crate:resolver
crate:resolver
crate:rustls
crate:server
crate:util
dependencies
docs
duplicate
easy
easy
enhance
enhance
enhance
feature:dns-over-https
feature:dns-over-quic
feature:dns-over-tls
feature:dnsssec
feature:global_lb
feature:mdns
feature:tsig
features:edns
has workaround
ops
perf
platform:WASM
platform:android
platform:fuchsia
platform:linux
platform:macos
platform:windows
pull-request
question
test
tools
tools
trust
unclear
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/hickory-dns#776
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @gopa-eg on GitHub (Oct 26, 2022).
Original GitHub issue: https://github.com/hickory-dns/hickory-dns/issues/1809
https://github.com/bluejekyll/trust-dns/blob/main/crates/server/src/server/server_future.rs#L95
join_next() is never called on inner_join - hence the inner_join will keep growing per dns-request
@bluejekyll commented on GitHub (Oct 27, 2022):
@jeff-hiner any chance you could look at this? I think it’s related to some of your changes. Could you verify if it’s an issue?
@jeff-hiner commented on GitHub (Oct 31, 2022):
Yeah we need to eventually clean these up. I'd normally suggest doing a lazy
try_join_nextright after that spawn, but that doesn't exist. Maybe anow_or_neverwrapper aroundjoin_next, in a loop?