[GH-ISSUE #1776] Add check for duplicate crate versions to cleanliness #765

New issue

Open

opened 2026-03-16 00:10:17 +03:00 by kerem · 3 comments

kerem commented

2026-03-16 00:10:17 +03:00

Owner

Originally created by @bluejekyll on GitHub (Sep 10, 2022).
Original GitHub issue: https://github.com/hickory-dns/hickory-dns/issues/1776

@bluejekyll At some point would be great, but no hurry at all.

As it is, trust-dns-resolver pulls in two versions of idna as reported for example by cargo deny check. But that is all.

warning[B004]: found 2 duplicate entries for crate 'idna'
   ┌─ /home/david/src/example/Cargo.lock:19:1
   │
19 │ ╭ idna 0.2.3 registry+https://github.com/rust-lang/crates.io-index
20 │ │ idna 0.3.0 registry+https://github.com/rust-lang/crates.io-index
   │ ╰────────────────────────────────────────────────────────────────^ lock entries
   │
   = idna v0.2.3
     └── trust-dns-proto v0.22.0
         └── trust-dns-resolver v0.22.0
             └── example v0.1.0
   = idna v0.3.0
     └── url v2.3.1
         └── trust-dns-proto v0.22.0
             └── trust-dns-resolver v0.22.0
                 └── example v0.1.0

Originally posted by @glts in https://github.com/bluejekyll/trust-dns/issues/1774#issuecomment-1242775942

Originally created by @bluejekyll on GitHub (Sep 10, 2022). Original GitHub issue: https://github.com/hickory-dns/hickory-dns/issues/1776 @bluejekyll At some point would be great, but no hurry at all. As it is, trust-dns-resolver pulls in two versions of idna as reported for example by `cargo deny check`. But that is all. ``` warning[B004]: found 2 duplicate entries for crate 'idna' ┌─ /home/david/src/example/Cargo.lock:19:1 │ 19 │ ╭ idna 0.2.3 registry+https://github.com/rust-lang/crates.io-index 20 │ │ idna 0.3.0 registry+https://github.com/rust-lang/crates.io-index │ ╰────────────────────────────────────────────────────────────────^ lock entries │ = idna v0.2.3 └── trust-dns-proto v0.22.0 └── trust-dns-resolver v0.22.0 └── example v0.1.0 = idna v0.3.0 └── url v2.3.1 └── trust-dns-proto v0.22.0 └── trust-dns-resolver v0.22.0 └── example v0.1.0 ``` _Originally posted by @glts in https://github.com/bluejekyll/trust-dns/issues/1774#issuecomment-1242775942_

kerem commented

2026-03-16 00:10:23 +03:00

Author

Owner

@djc commented on GitHub (Sep 10, 2022):

I would recommend against having a check in CI that fails the build due to this, since it might not always be actionable (depending on the upstream dependencies). (Especially since I can't override it when it fails.)

@djc commented on GitHub (Sep 10, 2022): I would recommend against having a check in CI that fails the build due to this, since it might not always be actionable (depending on the upstream dependencies). (Especially since I can't override it when it fails.)

kerem commented

2026-03-16 00:10:28 +03:00

Author

Owner

@bluejekyll commented on GitHub (Sep 11, 2022):

I haven’t looked into it yet. So there’s no way to add an exception?

@bluejekyll commented on GitHub (Sep 11, 2022): I haven’t looked into it yet. So there’s no way to add an exception?

kerem commented

2026-03-16 00:10:33 +03:00

Author

Owner

@djc commented on GitHub (Sep 12, 2022):

Hmm, I suppose we can make it default deny and add specific crates to the allow list.

https://embarkstudios.github.io/cargo-deny/checks/bans/cfg.html#example-config

Still not sure it's worth it.

@djc commented on GitHub (Sep 12, 2022): Hmm, I suppose we can make it default deny and add specific crates to the allow list. https://embarkstudios.github.io/cargo-deny/checks/bans/cfg.html#example-config Still not sure it's worth it.