[GH-ISSUE #1713] [resolver] Rustdoc for AsyncResolver incorrectly mentions a background future that needs to be spawned. #743

Open
opened 2026-03-16 00:06:57 +03:00 by kerem · 3 comments
Owner

Originally created by @abusch on GitHub (May 30, 2022).
Original GitHub issue: https://github.com/hickory-dns/hickory-dns/issues/1713

Describe the bug
Documentation for AsyncResolver, and most of its constructors, incorrectly says that a tuple of a resolver and a background future to spawn is returned.

To Reproduce
Steps to reproduce the behavior: see https://docs.rs/trust-dns-resolver/0.21.2/trust_dns_resolver/struct.AsyncResolver.html for instance.

Expected behavior
References to "a future that should be spawned on an executor to drive the background work" should be removed.

System:
n/a

Version:
Crate: resolver
Version: 0.21.2

Additional context
n/a

Originally created by @abusch on GitHub (May 30, 2022). Original GitHub issue: https://github.com/hickory-dns/hickory-dns/issues/1713 **Describe the bug** Documentation for `AsyncResolver`, and most of its constructors, incorrectly says that a tuple of a resolver and a background future to spawn is returned. **To Reproduce** Steps to reproduce the behavior: see https://docs.rs/trust-dns-resolver/0.21.2/trust_dns_resolver/struct.AsyncResolver.html for instance. **Expected behavior** References to "a future that should be spawned on an executor to drive the background work" should be removed. **System:** n/a **Version:** Crate: resolver Version: 0.21.2 **Additional context** n/a
Author
Owner

@djc commented on GitHub (May 30, 2022):

Thanks for the report. Would you be interested in submitting a PR proposal?

<!-- gh-comment-id:1140974189 --> @djc commented on GitHub (May 30, 2022): Thanks for the report. Would you be interested in submitting a PR proposal?
Author
Owner

@abusch commented on GitHub (May 30, 2022):

Sure, I'll give it a shot whenever i have a bit of time.

<!-- gh-comment-id:1141492056 --> @abusch commented on GitHub (May 30, 2022): Sure, I'll give it a shot whenever i have a bit of time.
Author
Owner

@djc commented on GitHub (May 31, 2022):

Great, thanks!

<!-- gh-comment-id:1141788504 --> @djc commented on GitHub (May 31, 2022): Great, thanks!
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/hickory-dns#743
No description provided.