mirror of
https://github.com/hickory-dns/hickory-dns.git
synced 2026-04-25 03:05:51 +03:00
[GH-ISSUE #1713] [resolver] Rustdoc for AsyncResolver incorrectly mentions a background future that needs to be spawned. #743
Labels
No labels
blocked
breaking-change
bug
bug:critical
bug:tests
cleanup
compliance
compliance
compliance
crate:all
crate:client
crate:native-tls
crate:proto
crate:recursor
crate:resolver
crate:resolver
crate:rustls
crate:server
crate:util
dependencies
docs
duplicate
easy
easy
enhance
enhance
enhance
feature:dns-over-https
feature:dns-over-quic
feature:dns-over-tls
feature:dnsssec
feature:global_lb
feature:mdns
feature:tsig
features:edns
has workaround
ops
perf
platform:WASM
platform:android
platform:fuchsia
platform:linux
platform:macos
platform:windows
pull-request
question
test
tools
tools
trust
unclear
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/hickory-dns#743
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @abusch on GitHub (May 30, 2022).
Original GitHub issue: https://github.com/hickory-dns/hickory-dns/issues/1713
Describe the bug
Documentation for
AsyncResolver, and most of its constructors, incorrectly says that a tuple of a resolver and a background future to spawn is returned.To Reproduce
Steps to reproduce the behavior: see https://docs.rs/trust-dns-resolver/0.21.2/trust_dns_resolver/struct.AsyncResolver.html for instance.
Expected behavior
References to "a future that should be spawned on an executor to drive the background work" should be removed.
System:
n/a
Version:
Crate: resolver
Version: 0.21.2
Additional context
n/a
@djc commented on GitHub (May 30, 2022):
Thanks for the report. Would you be interested in submitting a PR proposal?
@abusch commented on GitHub (May 30, 2022):
Sure, I'll give it a shot whenever i have a bit of time.
@djc commented on GitHub (May 31, 2022):
Great, thanks!