mirror of
https://github.com/hickory-dns/hickory-dns.git
synced 2026-04-24 18:55:55 +03:00
[GH-ISSUE #1709] I found a recursion which may cause stack overflow error #740
Labels
No labels
blocked
breaking-change
bug
bug:critical
bug:tests
cleanup
compliance
compliance
compliance
crate:all
crate:client
crate:native-tls
crate:proto
crate:recursor
crate:resolver
crate:resolver
crate:rustls
crate:server
crate:util
dependencies
docs
duplicate
easy
easy
enhance
enhance
enhance
feature:dns-over-https
feature:dns-over-quic
feature:dns-over-tls
feature:dnsssec
feature:global_lb
feature:mdns
feature:tsig
features:edns
has workaround
ops
perf
platform:WASM
platform:android
platform:fuchsia
platform:linux
platform:macos
platform:windows
pull-request
question
test
tools
tools
trust
unclear
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/hickory-dns#740
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @Ren-ZY on GitHub (May 21, 2022).
Original GitHub issue: https://github.com/hickory-dns/hickory-dns/issues/1709
The function read_inner at crates/proto/src/rr/domain/name.rs: 981:1: 981:93 is a recursive function.
Maybe Some special input can make it recursive deeply and cause stack overflow?
For example:
let btyes = vec![..............];
let mut d = BinDecoder::new(&bytes);
Name::read(&mut d);
@bluejekyll commented on GitHub (May 22, 2022):
Have you been able to create a stack overflow? The
read_innerrecursion has a requirement that it must point to an earlier section of the message for the compressed label. This bounds theread_innerin the sense that it can't infinitely recurse, eventually it would stop at the first index of the message.