mirror of
https://github.com/hickory-dns/hickory-dns.git
synced 2026-04-25 11:15:54 +03:00
[GH-ISSUE #1627] Regression when using Resolver::txt_lookup #713
Labels
No labels
blocked
breaking-change
bug
bug:critical
bug:tests
cleanup
compliance
compliance
compliance
crate:all
crate:client
crate:native-tls
crate:proto
crate:recursor
crate:resolver
crate:resolver
crate:rustls
crate:server
crate:util
dependencies
docs
duplicate
easy
easy
enhance
enhance
enhance
feature:dns-over-https
feature:dns-over-quic
feature:dns-over-tls
feature:dnsssec
feature:global_lb
feature:mdns
feature:tsig
features:edns
has workaround
ops
perf
platform:WASM
platform:android
platform:fuchsia
platform:linux
platform:macos
platform:windows
pull-request
question
test
tools
tools
trust
unclear
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/hickory-dns#713
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @glts on GitHub (Feb 5, 2022).
Original GitHub issue: https://github.com/hickory-dns/hickory-dns/issues/1627
I have been using
trust_dns_resolver::Resolver::txt_lookupsuccessfully with version 0.20.4.The same lookup now fails with version 0.21.0-alpha.4.
To reproduce:
Output with trust-dns-resolver 0.20.4:
Output with trust-dns-resolver 0.21.0-alpha.4:
I can reproduce this on two separate hosts (home and VPS).
@bluejekyll commented on GitHub (Feb 6, 2022):
Thanks the for the report. I think there are two potential changes related to this: #1556 and #1562
I was able to reproduce this with the
resolvecommand and when enabling debug, you can see that the difference between the two requests is that in the 0.20 version it fails the intial request, then reattempts with TCP. In the 0.21 (main) branch, it appears that the promotion to TCP resolution isn't attempted.My guess is that this is due to the larger record response on all the TXT records, and it requires TCP (> 512 byte reponse).
@peterthejohnston, I think we're going to need to revisit some of those changes. @glts, thank you for finding this before we pushed the next release for 0.21.
@bluejekyll commented on GitHub (Feb 7, 2022):
#1629 appears to resolve this. I want to make sure that we have a test case to reproduce this before merging.
@bluejekyll commented on GitHub (Feb 8, 2022):
The patch for this was released today in
v0.21.0-alpha.5.