mirror of
https://github.com/hickory-dns/hickory-dns.git
synced 2026-04-25 03:05:51 +03:00
[GH-ISSUE #1597] Breaking options change for HTTPS-only queries in 0.21 alpha #706
Labels
No labels
blocked
breaking-change
bug
bug:critical
bug:tests
cleanup
compliance
compliance
compliance
crate:all
crate:client
crate:native-tls
crate:proto
crate:recursor
crate:resolver
crate:resolver
crate:rustls
crate:server
crate:util
dependencies
docs
duplicate
easy
easy
enhance
enhance
enhance
feature:dns-over-https
feature:dns-over-quic
feature:dns-over-tls
feature:dnsssec
feature:global_lb
feature:mdns
feature:tsig
features:edns
has workaround
ops
perf
platform:WASM
platform:android
platform:fuchsia
platform:linux
platform:macos
platform:windows
pull-request
question
test
tools
tools
trust
unclear
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/hickory-dns#706
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @ecton on GitHub (Dec 5, 2021).
Original GitHub issue: https://github.com/hickory-dns/hickory-dns/issues/1597
Describe the bug
If you are using a resolver with only an HTTPS configuration, you now need to specify
try_tcp_on_error = trueduring configuration, otherwise you get aNoConnectionserror returned.To Reproduce
Steps to reproduce the behavior:
Expected behavior
I would expect a pure HTTPS configuration to not require a setting named
try_tcp_on_errorto be set. To me (a casual user of the library), I would expect with a single HTTPS nameserver configured, the query would be over TCP by default, and a "try on error" configuration wouldn't be necessary. The CHANGELOG entry did not seem to imply that it would impact this situation -- I had to open the pull request to try to understand what that entry actually meant.The time I spent trying to figure out what change might have impacted me is what led me to filing this report. Even if no changes are made, someone else who encounters this might discover this report when searching.
Thank you for the excellent library!
Version:
Crate: resolver
Version: 0.21.0-alpha-4
@djc commented on GitHub (Dec 5, 2021):
Have you tried on main? I think this might be #1592.
@ecton commented on GitHub (Dec 5, 2021):
Thank you, this is indeed the same issue. Sorry for the extra traffic!
@bluejekyll commented on GitHub (Dec 6, 2021):
I’ll try and publish a new alpha this week.