[GH-ISSUE #1515] Maybe `async_trait` is not needed when feature `tokio-runtime` is disabled. #686

New issue

Open

opened 2026-03-15 23:48:30 +03:00 by kerem · 4 comments

kerem commented

2026-03-15 23:48:30 +03:00

Owner

Originally created by @FH0 on GitHub (Jul 6, 2021).
Original GitHub issue: https://github.com/hickory-dns/hickory-dns/issues/1515

https://github.com/bluejekyll/trust-dns/blob/main/crates/proto/src/lib.rs#L209-#L220

Originally created by @FH0 on GitHub (Jul 6, 2021). Original GitHub issue: https://github.com/hickory-dns/hickory-dns/issues/1515 https://github.com/bluejekyll/trust-dns/blob/main/crates/proto/src/lib.rs#L209-#L220

kerem commented

2026-03-15 23:48:36 +03:00

Author

Owner

@djc commented on GitHub (Jul 6, 2021):

Would be good to make the dependency optional where possible. Would you mind submitting a PR?

@djc commented on GitHub (Jul 6, 2021): Would be good to make the dependency optional where possible. Would you mind submitting a PR?

kerem commented

2026-03-15 23:48:41 +03:00

Author

Owner

@FH0 commented on GitHub (Jul 6, 2021):

It is difficult for me to help with PR. I post this issue because I run cargo tree after tokio-runtime disabled.

@FH0 commented on GitHub (Jul 6, 2021): It is difficult for me to help with PR. I post this issue because I run `cargo tree` after `tokio-runtime` disabled.

kerem commented

2026-03-15 23:48:46 +03:00

Author

Owner

@djc commented on GitHub (Jul 6, 2021):

What's your use case? Are you using another runtime, or do you want to use trust-dns synchronously?

@djc commented on GitHub (Jul 6, 2021): What's your use case? Are you using another runtime, or do you want to use trust-dns synchronously?

kerem commented

2026-03-15 23:48:51 +03:00

Author

Owner

@FH0 commented on GitHub (Jul 6, 2021):

Sorry for the late reply, I only need the basic functions, which is the synchronization you said.

@FH0 commented on GitHub (Jul 6, 2021): Sorry for the late reply, I only need the basic functions, which is the synchronization you said.