[GH-ISSUE #1411] Support `&String` for `IntoName` #667

New issue

Closed

opened 2026-03-15 23:44:30 +03:00 by kerem · 5 comments

kerem commented

2026-03-15 23:44:30 +03:00

Owner

Originally created by @Inrin on GitHub (Mar 14, 2021).
Original GitHub issue: https://github.com/hickory-dns/hickory-dns/issues/1411

Is your feature request related to a problem? Please describe.
no

Describe the solution you'd like
Implement IntoName Trait for &'a String

Describe alternatives you've considered
Just use:

as_str() or &*foo
Clone the String to not move it.

Additional context
https://docs.rs/trust-dns-resolver/0.20.0/trust_dns_resolver/struct.Resolver.html#method.txt_lookup
implies it behaves like a &str Parameter.

https://docs.rs/trust-dns-resolver/0.20.0/trust_dns_resolver/struct.AsyncResolver.html#method.txt_lookup
just mentions a string

So my first try had been to use: &foo where foo is a String.

Originally created by @Inrin on GitHub (Mar 14, 2021). Original GitHub issue: https://github.com/hickory-dns/hickory-dns/issues/1411 **Is your feature request related to a problem? Please describe.** no **Describe the solution you'd like** Implement `IntoName` Trait for `&'a String` **Describe alternatives you've considered** Just use: 1) `as_str()` or `&*foo` 2) Clone the String to not move it. **Additional context** https://docs.rs/trust-dns-resolver/0.20.0/trust_dns_resolver/struct.Resolver.html#method.txt_lookup implies it behaves like a `&str` Parameter. https://docs.rs/trust-dns-resolver/0.20.0/trust_dns_resolver/struct.AsyncResolver.html#method.txt_lookup just mentions *a string* So my first try had been to use: `&foo` where foo is a `String`.

kerem

2026-03-15 23:44:30 +03:00

closed this issue
added the
enhance

crate:proto

easy

has workaround
labels

kerem commented

2026-03-15 23:44:46 +03:00

Author

Owner

@bluejekyll commented on GitHub (Mar 14, 2021):

You can use this method: https://doc.rust-lang.org/alloc/string/struct.String.html#method.as_str, though, be aware, &str will still allocate for Name. I think adding the other impl for &String would be fine, but as_str should work in the meantime, right?

@bluejekyll commented on GitHub (Mar 14, 2021): You can use this method: https://doc.rust-lang.org/alloc/string/struct.String.html#method.as_str, though, be aware, `&str` will still allocate for `Name`. I think adding the other impl for `&String` would be fine, but `as_str` should work in the meantime, right?

kerem commented

2026-03-15 23:44:52 +03:00

Author

Owner

@Inrin commented on GitHub (Mar 14, 2021):

Yes sure!
I used as_str() as mentioned in "Describe alternatives you've considered".

This is just a "convenience" feature request ;)

@Inrin commented on GitHub (Mar 14, 2021): Yes sure! I used `as_str()` as mentioned in "Describe alternatives you've considered". This is just a "convenience" feature request ;)

kerem commented

2026-03-15 23:44:57 +03:00

Author

Owner

@bluejekyll commented on GitHub (Mar 14, 2021):

yeah, I saw that. I was confused if that was working as expected or not. We can add that conversion if it simplifies things.

@bluejekyll commented on GitHub (Mar 14, 2021): yeah, I saw that. I was confused if that was working as expected or not. We can add that conversion if it simplifies things.

kerem commented

2026-03-15 23:45:02 +03:00

Author

Owner

@Inrin commented on GitHub (Mar 14, 2021):

Would be nice!
Thank you!

@Inrin commented on GitHub (Mar 14, 2021): Would be nice! Thank you!

kerem commented

2026-03-15 23:45:07 +03:00

Author

Owner

@bluejekyll commented on GitHub (Apr 9, 2021):